1869994 - video with border-radius over a video loses rounding

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Robert]

Attachment: video_border-radius_over_video.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:120.0) Gecko/20100101 Firefox/120.0

Steps to reproduce:

Video over background video loses rounded corners.

Actual results:

Square corners on video

Expected results:

Rounded corners

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7f516f079dd477e68270d19861eaa4513cfb3270&tochange=d3828ca7337d8ffb2112780580a3fc4e0c8ea6f2

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:gw, since you are the author of the regressor, bug 1849680, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Glenn Watson [:gw]]

When testing on Linux, it seems to not show the second video, even if I disable border-radius from the test case. Do you see the same?

Comment 4

[Robert]

Attachment: Testing on windows 10 22H2 (updated) - firefox 120.0.1

Comment 5

[Robert]

(In reply to Glenn Watson [:gw] from comment #3)

When testing on Linux, it seems to not show the second video, even if I disable border-radius from the test case. Do you see the same?

I see this on windows 10 https://bugzilla.mozilla.org/attachment.cgi?id=9368765

Comment 6

[Glenn Watson [:gw]]

Attachment: Bug 1869994 - Fix overlapping underlay compositor surfaces with masks

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e96bd5ec21a2
Fix overlapping underlay compositor surfaces with masks r=gfx-reviewers,lsalzman

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e96bd5ec21a2

Comment 9

[Robert]

Works, perfect in Nightly. Thanks

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Release as a possible dot release ride-along?

Comment 11

[Glenn Watson [:gw]]

Attachment: Bug 1869994 - Fix overlapping underlay compositor surfaces with masks

Original Revision: https://phabricator.services.mozilla.com/D196501

Comment 12

[Glenn Watson [:gw]]

Sure, I think I've filled out the new form for that now.

Comment 13

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• String changes made/needed: None
• Explanation of risk level: Small patch
• Needs manual QE test: yes
• User impact if declined: Artifacts with rounded video on top of compositor surfaces
• Steps to reproduce for manual QE testing: Per bug report
• Is Android affected?: yes
• Risk associated with taking this patch: Low
• Fix verified in Nightly: yes

Comment 14

[Ciprian Georgiu, Desktop QA]

I have reproduced this issue with an affected Nightly build, 122.0a1 (20231208094241), under macOS 13.

The issue is verified as fixed on latest Beta 122.0b1 (20231218153201), under macOS 13, Ubuntu 20.04 and Win 11.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/76e457123e86

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Added to the 121.0.1 relnotes:

Fixed missing rounded corners for videos playing over top of another video

Comment 18

[Ciprian Georgiu, Desktop QA]

This is also verified as fixed on Firefox 121.0.1 running Win 11 x64, macOS 14 and Ubuntu 20.04 x64.