1870034 - Network Proxy Settings UI states proxy-dns only supported in SOCKSv5, but seems also supported in SOCKSv4

Status: RESOLVED DUPLICATE of bug 1454850

(Core :: Networking: Proxy, defect, P3)

Description

[erosman]

Issue

Proxy DNS seems to be supported for both SOCKS4 & SOCKS (SOCKS5), while the UI states SOCKS v5 only.

User-Interface

Settings -> Network Settings -> Proxy DNS

Proxy DNS when using SOCKS v5

References

https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/preferences/connection.ftl#80
https://searchfox.org/mozilla-central/source/toolkit/components/extensions/schemas/proxy.json#80
https://searchfox.org/mozilla-central/rev/4d6a5b97428760d15bfcad13f8fc81439370a7ec/netwerk/dns/DNSServiceBase.cpp#55

https://searchfox.org/mozilla-central/source/toolkit/components/extensions/ProxyChannelFilter.sys.mjs#143

if (
  proxyDNS &&
  type !== PROXY_TYPES.SOCKS &&
  type !== PROXY_TYPES.SOCKS4
) {
  throw new ExtensionError(
    `ProxyInfoData: proxyDNS can only be true for SOCKS proxy servers`
  );

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/ProxyInfo

proxyDNS

boolean. If true, the proxy server is used to resolve certain DNS queries (only usable with "socks4" and "socks"). Defaults to false.

Comment 1

[Manuel Bucher [:manuel]]

Hi, thanks for taking the time to create the bug.

After doing some testing for Bug 1741375, I noticed that the UI disables the "Proxy DNS when using SOCKS v5" element when selecting SOCKSv4. According to Wikipedia, SOCKSv4 really doesn't support name resolution, but an extension SOCKSv4a does.[1]. We do seem to support SOCKSv4a[2], therefore some more UI work than just changing the string is necessary.

So the change might need to change the string to "Proxy DNS when using SOCKS" and make it selectable no matter which SOCKS proxy version is selected.

Comment 2

[BMO Automation]

Moving bug to Core/Networking: Proxy.

Comment 3

[Manuel Bucher [:manuel]]

Fixed in Bug 1454850. (landing together with Bug 1741375 splitting up the pref into one for socks4 and one for socks5)