1870037 - Remove [SecureContext] from Gamepad

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P3)

Description

[Mayank Bansal]

Uncaught RuntimeError: index out of bounds
createExportWrapper http://auburn.github.io/FastNoiseLite/:1
callMain http://auburn.github.io/FastNoiseLite/:1
A http://auburn.github.io/FastNoiseLite/:1
run http://auburn.github.io/FastNoiseLite/:1
line 1 > WebAssembly.instantiate:83209:1
<anonymous> http://auburn.github.io/FastNoiseLite/ line 1 > WebAssembly.instantiate:83209
<anonymous> http://auburn.github.io/FastNoiseLite/ line 1 > WebAssembly.instantiate:355877
<anonymous> http://auburn.github.io/FastNoiseLite/ line 1 > WebAssembly.instantiate:54966
createExportWrapper http://auburn.github.io/FastNoiseLite/:1
callMain http://auburn.github.io/FastNoiseLite/:1
A http://auburn.github.io/FastNoiseLite/:1
run http://auburn.github.io/FastNoiseLite/:1

Comment 1

[Jan de Mooij [:jandem]]

This works for me on both Nightly and Release on Mac M1. Maybe x64 specific?

Comment 2

[Julian Seward [:jseward]]

Fails for me on x86_64-linux, both with (wasm-) baseline and Ion.

Comment 3

[Ryan Hunt [:rhunt]]

I'm getting failures on my Mac M1, so I don't think it's x64 specific. Seems to be with both baseline and Ion for me as well.

Comment 4

[Mayank Bansal]

This seems to be the regression range for me : https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3350b68026ed51868a2100acb87d1833d61ac486&tochange=61484a56d30a2bbc5a3d6903e6258ae3acd714bf

Comment 5

[Yury Delendik (:yury)]

The application still works in secure context: https://auburn.github.io/FastNoiseLite/

Via debugging you can see that navigator.getGamepads is requested in JS, and secure context is enforced by bug 1704005 (the commit from it in the regression range).

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1704005

:marcos, since you are the author of the regressor, bug 1704005, could you take a look?

For more information, please visit BugBot documentation.

Comment 7

[Chris Martin [:cmartin]]

Changing to P3 -- Unfortunately, nothing in Gamepad (short of a security emergency) is getting P1 status anymore.

Comment 8

[Gian-Carlo Pascutto [:gcp]]

I'm going to WONTFIX because to my understanding this is "working exactly as intended" from bug 1704005. I'll comment there.

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Actually, let me use this bug to revert our decision in bug 1704005.

Comment 10

[marcos]

please also raise this on the standard side.

Comment 11

[Kagami Rosylight [:saschanaz] (they/them)]

Yes, I'll ping the spec and also submit the intent to ship. Thanks for pointing that out 👍

Some note while we are at it: Everyone had their pref but never turned them on

• WebKit: https://searchfox.org/wubkat/rev/eb1d01ca7f489dc74c38dd9af08420cd70d52b43/Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp#86-92
• Blink: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc;l=131-147;drc=60e39e7dbe956ab78ef3745981cc05e16683d934

Comment 12

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1870037 - Remove [SecureContext] from Gamepads r=#dom-core

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ffbf643b482
Remove [SecureContext] from Gamepads r=webidl,smaug

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44678 for changes under testing/web-platform/tests

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2ffbf643b482

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:saschanaz, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 19

[Kagami Rosylight [:saschanaz] (they/them)]

I'll let it ride the train.