1870039 - [wpt-sync] Sync PR 43666 - Revert "Support number producing css math functions in ConvertScale"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43666 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43666
Details from upstream follow.

[e-mail] <[e-mail]> wrote:

Revert "Support number producing css math functions in ConvertScale"

This reverts commit d694eb2ed43a9eb892f36825c8a1ec5ee060e780.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5666459860598784

Sample build with failed test: https://ci.chromium.org/b/8761736444845514609
Affected test(s):
ninja://:blink_wpt_tests/external/wpt/css/css-values/progress-computed.tentative.html

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5666459860598784&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5116383&type=BUG

Original change's description:

Support number producing css math functions in ConvertScale

Currently, StyleBuilderConverter::ConvertScale directly calls
GetDoubleValue() which is incorrect for math functions, rewrite it
to use ComputeNumber with CssToLengthConversionData instead.

Note: the crash is due to the parse time percent resolution in
ConsumeNumberOrPercent, which doesn't work with math functions yet.
It will be fixed in the following CL, meanwhile the added test case
covers the changed functionality.

Bug: 1505817
Change-Id: Icf553423d09b9ff71ebc3b625c06e10fec637352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5116383
Commit-Queue: Daniil Sakhapov \<[e-mail]>
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1237458}

Bug: 1505817
Change-Id: I7789b492c2eb711a3a2b73968f0ca3611205cf2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/5121600
WPT-Export-Revision: cf3470168d68dee4572aa58548e3ba4c210509fb

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f2035fcd7c2
[wpt PR 43666] - Revert "Support number producing css math functions in ConvertScale", a=testonly

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8f2035fcd7c2