1870135 - Revamp logic behind data size parameters for clear history dialog

Status: NEW

(Toolkit :: Data Sanitization, enhancement, P3)

Description

[Harshit Sohaney [:hsohaney]]

The logic behind connecting the Sanitizer and Sanitize Dialog to get data sizes can be simplified and made easier to read. The data fetching code is currently inefficient since it has to loop through all sites and count data, instead of doing db fetching through the clearDataService.
https://searchfox.org/mozilla-central/rev/8340afd1fb3e7b2727d2efb47df1bd3112db7213/browser/modules/SiteDataManager.sys.mjs#401

Comment 1

[Paul Zühlcke [:pbz]]

Harshit, is this bug still applicable? If so, could you please update the description to explain better what needs to be updated?

Comment 2

[Harshit Sohaney [:hsohaney]]

I think the code is a bit inefficient right now since it has to loop through all the sites to get the values: https://searchfox.org/mozilla-central/rev/8340afd1fb3e7b2727d2efb47df1bd3112db7213/browser/modules/SiteDataManager.sys.mjs#401
We should probably make this better, but it is a backlog item. What are your thoughts?

Comment 3

[Paul Zühlcke [:pbz]]

How could we make it more efficient? :) Could you please add that to the bug description?