1870138 - Add support for overriding search engine URLs from remote settings

Status: RESOLVED FIXED

(Firefox :: Search, task)

Description

[Mike Kaply [:mkaply]]

We'd like the ability to override some search engine params from remote settings.

This will allow us to update just some URLs for search engines without changing the entire search config.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1870138 - Add remote settings support for search overrides. r?standard8

Comment 2

[Mike Kaply [:mkaply]]

Attachment: DATA REVIEW REQUEST.txt

Data review request for new search with contextual services ping.

Comment 3

[Travis Long [:travis_]]

Comment on attachment 9371123 [details]
DATA REVIEW REQUEST.txt

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the data preferences in the application settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent collection to be monitored over time by [e-mail]

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1 & 2

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7efc40636fa
Add remote settings support for search overrides. r=Standard8

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b7efc40636fa

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Bug 1870138 - Add remote settings support for search overrides. r?standard8

Original Revision: https://phabricator.services.mozilla.com/D196490

Comment 7

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• Risk associated with taking this patch: Low
• String changes made/needed: None
• Fix verified in Nightly: yes
• Explanation of risk level: Automated test, tested by QA and only affects search if remote settings is active
• Is Android affected?: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: QE is on the hook and has the steps
• User impact if declined: Amazon searches not attributed to us.

Comment 8

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• User impact if declined: Amazon searches not attributed to us.
• Is Android affected?: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: QE is on the hook and has the steps
• Fix verified in Nightly: yes
• Explanation of risk level: Automated test, tested by QA and only affects search if remote settings is active
• Risk associated with taking this patch: Low
• String changes made/needed: None

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/1c73ddceaf7f

Comment 10

[Cristian Baica [:cbaica], Release Desktop QA]

Beta testing (Fx122.0b8) for the uplift was completed. The test results can be viewed here.

RS changes can be pushed to production once the code reaches the RC branch.