Closed Bug 1870169 Opened 10 months ago Closed 9 months ago

[wpt-sync] Sync PR 43682 - Fix checkbox, radio baseline position when in vertical writing mode

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
123 Branch
Tracking Flags:
Tracking Status
firefox123 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43682 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43682
Details from upstream follow.

Di Zhang <dizhangg@chromium.org> wrote:

Fix checkbox, radio baseline position when in vertical writing mode

We update LogicalBoxFragment::BaselineMetrics such that if all following
conditions are met, then the baseline should be centered:

  • writing mode is vertical
  • control part is radio or checkbox
  • baseline type is not alphabetic

Further, for vertical writing mode, we map the correct margin values to
the ascent/descent baseline values.

Change-Id: Ib87b1c412181acb0170bb4ea017383a9eb73df1e
Bug: 1511382
Reviewed-on: https://chromium-review.googlesource.com/5123415
WPT-Export-Revision: dba3bc0f0aa92abe1dde8fb943ffc1ee8704752f

Component: web-platform-tests → Layout
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/692913c58eff [wpt PR 43682] - Fix checkbox, radio baseline position when in vertical writing mode, a=testonly
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56f0139fddb8 [wpt PR 43682] - Fix checkbox, radio baseline position when in vertical writing mode, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/56f0139fddb8

Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox123: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.