Closed
Bug 1870173
Opened 2 years ago
Closed 2 years ago
Deadlock with FFmpegVideoEncoder in WebRTC
Categories
(Core :: Audio/Video: Web Codecs, defect)
Core
Audio/Video: Web Codecs
Tracking
()
RESOLVED
FIXED
122 Branch
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: pehrsons, Assigned: chunmin)
References
Details
Attachments
(3 files)
FFmpegVideoEncoder::Shutdown shuts down its mTaskQueue. But this TaskQueue was injected via the ctor, and in the WebRTC case it is owned by WebrtcMediaDataEncoder who created it. What causes the deadlock is that WebrtcMediaDataEncoder tries to use the TaskQueue after FFmpegVideoEncoder has shut it down.
|
Assignee | |
Comment 1•2 years ago
|
||
Since FFmpegVideoEncoder doesn't own the mTaskQueue, it shouldn't shut
it down.
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D196504
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D196514
Pushed by cchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c13e38877f2
Don't shut task queue down in FFmpegVideoEncoder r=media-playback-reviewers,pehrsons,padenot
https://hg.mozilla.org/integration/autoland/rev/66a6c6315f15
Move ffmpeg version check to ctor r=media-playback-reviewers,pehrsons,padenot
https://hg.mozilla.org/integration/autoland/rev/6bfe17b7b9cc
Add thread check and log in ProcessReconfigure r=media-playback-reviewers,pehrsons,padenot
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4c13e38877f2
https://hg.mozilla.org/mozilla-central/rev/66a6c6315f15
https://hg.mozilla.org/mozilla-central/rev/6bfe17b7b9cc
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•