1870214 - inspector single click activates url

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[zlice]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0

Steps to reproduce:

• go to https://www.w3schools.com/html/tryit.asp?filename=tryhtml_images_trulli
• right click on image and press q for inspector
• click on src jpg in img tag

Actual results:

goes to image https://www.w3schools.com/html/pic_trulli.jpg

Expected results:

double click to highlight, ctrl/shift + click to go to image

i'm not sure what the intended behavior of https://bugzilla.mozilla.org/show_bug.cgi?id=1864186 is supposed to be

but mozregression lead to

2023-12-14T22:58:49.379000: DEBUG : Found commit message:
Bug 1864186 - [devtools] Add links for invoketarget attributes. r=devtools-reviewers,bomsy.

Differential Revision: https://phabricator.services.mozilla.com/D193316

2023-12-14T22:58:49.379000: DEBUG : Did not find a branch, checking all integration branches
2023-12-14T22:58:49.380000: INFO : The bisection is done.
2023-12-14T22:58:49.380000: INFO : Stopped


app_name: firefox
build_date: 2023-11-16 18:19:19.766000
build_file: /home/zlice/.mozilla/mozregression/persist/9f244834bdc9-shippable--autoland--target.tar.bz2
build_type: integration
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/eztAyDdrRb2Bm_jk2xycyg/runs/0/artifacts/public%2Fbuild%2Ftarget.tar.bz2
changeset: 9f244834bdc93fa40d3b73b13baa22ac0214c415
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5dba86b1842a5256c2845d69a7cebd605267d535&tochange=9f244834bdc93fa40d3b73b13baa22ac0214c415
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: eztAyDdrRb2Bm_jk2xycyg

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Inspector' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Based on comment #0, this bug contains a bisection range found by mozregression. However, the Regressed by field is still not filled.

:nchevobbe, since you are the author of the changes in the range, if possible, could you fill the Regressed by field and investigate this regression?

For more information, please visit BugBot documentation.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

this is probably an oversight from Bug 1850953 , I'll have a look

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1870214 - [devtools] Fix condition in MarkupContainer _onClick. r=#devtools-reviewers.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6410c76f4440
[devtools] Fix condition in MarkupContainer _onClick. r=devtools-reviewers,bomsy.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6410c76f4440

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1850953

Comment 8

[Donal Meehan [:dmeehan]]

:nchevobbe would you like to nominate this for a beta uplift?
Does it also need a release uplift request for a dot ride-along, or should it ride the trains?

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1870214 - [devtools] Fix condition in MarkupContainer _onClick. r=#devtools-reviewers.

Original Revision: https://phabricator.services.mozilla.com/D196724

Comment 10

[Phabricator Automation]

Uplift Approval Request

• User impact if declined: clicking on some attribute in the markup view will open a link and the user won't be able to modify the attribute
• Needs manual QE test: no
• String changes made/needed: -
• Is Android affected?: no
• Explanation of risk level: devtools only single line change, covered by mochitest
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Risk associated with taking this patch: low
• Steps to reproduce for manual QE testing: -

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Donal Meehan [:dmeehan] from comment #8)

:nchevobbe would you like to nominate this for a beta uplift?
Does it also need a release uplift request for a dot ride-along, or should it ride the trains?

I requested the uplift on Lando

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/32b176eac997