1870291 - use `ruff` instead of `flake8` in moz-phab

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement)

Description

[Connor Sheehan [:sheehan]]

We should switch moz-phab from flake8 to ruff. We can also use some of ruff's linting capabilities to mass fix certain oddities in the codebase, namely switching to dict literals instead of calling the dict builtin.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: style: use ruff instead of flake8 (Bug 1870291) r?zeid

Switch from flake to ruff for styling. Update test_style.py
to lint the codebase with ruff.

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: styling: run `ruff --fix --unsafe-fixes` on codebase (Bug 1870291) r?zeid

Run ruff across the entire codebase, then run with --unsafe-fixes
and manually vet their correctness.

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: linting: rename some single-letter variables (Bug 1870291) r?zeid

Comment 4

[Connor Sheehan [:sheehan]]

Attachment: linting: add `noqa` to special case of importing after setting env var (Bug 1870291) r?zeid

Comment 5

[Connor Sheehan [:sheehan]]

Attachment: styling: add `noqa: B019` to lru_cache calls (Bug 1870291) r?zeid

Add a noqa for rule B019 to uses of lru_cache. Using the
lru cache in this way is a problem as the self value is used
as a cache key, which means a reference to the instance is kept
around by the cache, which can cause a memory leak since the
instance can't be garbage collected.

In our case, there is only ever one instance of a Repository
for the lifetime of the program, so we aren't worried about
an issue with the garbage collector.

Comment 6

[Connor Sheehan [:sheehan]]

Attachment: ruff: check for `--unsafe-fixes` in lint test (Bug 1870291) r?zeid

Comment 7

[Mathew Hodson]

Attachment: requirements: update Windows requirements (Bug 1870291)