Closed Bug 1870396 Opened 3 months ago Closed 2 months ago

Use GuardFuse to speed up destructuring

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox123 --- fixed

People

(Reporter: mgaudet, Assigned: mgaudet)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sp3])

Attachments

(2 files, 1 obsolete file)

The initial machinery to use GuardFuse to optimize destructuring will land in Bug 1855301; this bug should track us actually turning on the optimized destructuring code.

Whiteboard: [sp3]

This speeds up a microbenchmark like the following by 33%.

function foo(x) {
    var b;
    [b] = x;
    return b;
}
let start = performance.now();
for (var i = 0; i < 200_000; i++) {
    foo([1, 2, 3]);
}
let end = performance.now();
console.log(end - start);
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED

Comment on attachment 9369241 [details]
Bug 1870396 - Use a fuse check to speed up destructuring optimization r?jandem,iain

Revision D194293 was moved to bug 1855301. Setting attachment 9369241 [details] to obsolete.

Attachment #9369241 - Attachment is obsolete: true
Blocks: fuse
Depends on: 1870727
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4665ed600ede
Enable fuse-guarded destructuring optimization by default r=iain
https://hg.mozilla.org/integration/autoland/rev/79a6322a49b2
Add pref for fuse-guarded destructuring r=iain
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.