1870401 - Duration of encoded data in FFmpegVideoEncoder is always 0

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[C.M.Chang[:chunmin]]

The duratoin of the encoded data in FFmpegVideoEncoder is always 0. It's probably limited by the FFmpeg's API. An alternative is to save the duration before encoding and retrieve the duration after encoding, like what FFmpegVideoDecoder.cpp did (mDurationMap) for older ffmpeg versions.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1870401 - Correct include order

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1870401 - Simplify AVFrame's duration settings

Depends on D196640

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1870401 - Set duration for ffmpeg version < 60

AV_CODEC_FLAG_FRAME_DURATION was introduced in ffmpeg 60. For older
ffmpeg versions, we can simply save the duration in a map and then
retrieve it when needed, as what FFmpegVideoDecoder did.

Depends on D196641

Comment 4

[Phabricator Automation]

Comment on attachment 9369021 [details]
Bug 1870401 - Correct include order

Revision D196640 was moved to bug 1872204. Setting attachment 9369021 [details] to obsolete.

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1870401 - Move H264AVCC lines

Depends on D196683

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1870401 - Add duration tests

Depends on D197355

Comment 7

[C.M.Chang[:chunmin]]

Attachment: Bug 1870401 - clang-format TestMediaDataEncoder.cpp

Run

./mach clang-format --path dom/media/gtest/TestMediaDataEncoder.cpp

Depends on D196683

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8c1d0bff9dc
Simplify AVFrame's duration settings r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/cf64542b8a45
Set duration for ffmpeg version < 60 r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/5d9e038ddb39
clang-format TestMediaDataEncoder.cpp r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/ff9dcb89337a
Move H264AVCC lines r=media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/697b731b550c
Add duration tests r=media-playback-reviewers,alwu

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c8c1d0bff9dc
https://hg.mozilla.org/mozilla-central/rev/cf64542b8a45
https://hg.mozilla.org/mozilla-central/rev/5d9e038ddb39
https://hg.mozilla.org/mozilla-central/rev/ff9dcb89337a
https://hg.mozilla.org/mozilla-central/rev/697b731b550c