1870419 - Fix google, distributions, and database tests in searchconfigs tests

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Comment 1

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1870419 - Fix google, distributions, and database tests in searchconfigs tests folder. r=Standard8!

The copyObject function in SearchEngineSelector was performing a shallow copy of
the objects from the config. Therefore, the config was being modified because
the copied engine had pointers to the inner object and array from the search
config.

To fix the issue, the copyObject function is now changed to deepCopyObject
function, where we are performing a deep copy of the nested object or array
rather than shallow copies. When we loop over and apply the variant engine
properties cumulatively, they should not modify the original search config.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d05d212e5390
Fix google, distributions, and database tests in searchconfigs tests folder. r=Standard8

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d05d212e5390