When grabbing the next story id, sometimes it is invalid so we should try to grab the next one up to 5 tries
Categories
(bugzilla.mozilla.org :: Phabricator Integration, enhancement)
Tracking
()
People
(Reporter: dkl, Assigned: dkl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The majority of the time the reason, the phabbugz daemon gets hung up because it queries for a feed story id that does not exist in the Phabricator database. I am not sure at the moment yet why there are gaps in the ids, but when this happens Phabricator will loop back around and try the same ID again. This causes the queue to be backed up and newer revisions will not get updated properly.
My proposal is to wrap the call in an try/catch and examine the error message. When the error message matches the known error from conduit when an ID queried for is not valid, increment the ID by 1 and try the next one. If the next is also the same error and is invalid, then try up to a maximum of 5 times.
When I manually do this, I have never had to go more than 2-3 times before everything starts to work again. I manually update the last feed ID value in the phabbugz table of the BMO database.
|
||
Comment 1•2 years ago
|
||
|
Assignee | |
Comment 2•2 years ago
|
||
Description
•