1870582 - Add mChannelId attribute to nsFileChannel

Status: RESOLVED FIXED

(Core :: Networking: File, task, P2)

Description

[Julian Descottes [:jdescottes]]

Extracted from bug 1000540.
This is a blocker to show file:// resources in the netmonitor.

Comment 1

[Julian Descottes [:jdescottes]]

Dylan, can you move your last backed-out patch from Bug 1000540 to this one? Thanks!

Comment 2

[Dylan]

Attachment: Bug 1870582 - added mChannelId attribute to nsFileChannel. r=valentin

Comment 3

[Dylan]

Attachment: Pernosco trace

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:dotoole, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 5

[Dylan]

Attachment: Bug 1870582 - added mChannelId attribute to nsFileChannel. r=valentin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/687b59c68abe
added mChannelId attribute to nsFileChannel. r=valentin,necko-reviewers,profiler-reviewers,canaltinova

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1870580, Bug 1870582) for causing devtools failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5608a954442b4aabf36915b32bf88f9771b6e7fb&selectedTaskRun=a8z_9VNtRvi-zmsfgCg9dg.0

Logs: https://treeherder.mozilla.org/logviewer?job_id=446361528&repo=autoland&lineNumber=7106
https://treeherder.mozilla.org/logviewer?job_id=446361534&repo=autoland&lineNumber=17660

Backout: https://hg.mozilla.org/integration/autoland/rev/84881cb47fa46377fd54fcfb36d395a61a4a70f6

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61d02f4eff18
added mChannelId attribute to nsFileChannel. r=valentin,necko-reviewers,profiler-reviewers,canaltinova

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/61d02f4eff18