1870652 - In search-config-v2 change the defaultEngines records to have a single field for default/defaultPrivate matches

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

On the engine orders record in search-config-v2, we've implemented an exact match or starts with match mechanism. This allows us to specify an engine identifier as wikipedia for an exact match, or wikipedia* for a starts with match.

We want to bring that across to the default engines record so that we can drop the default vs defaultStartsWith splits (normal + private), and have more consistency within the configuration.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1870652 - In search-config-v2 change the defaultEngines records to have a single field for default/defaultPrivate matches. r?mcheang!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1870652 - Remove unnecessary additionalProperties requirement in search-config-v2-schema. r?mcheang!

Drop the requirement for disallowing additional properties in the order section as remote settings as its own properties, and this wasn't meant to be included.

We do check additional properties in xpcshell-tests, but need to allow for additional properties at runtime in case configurations are extended.

Depends on D196737

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bda3f55164a
In search-config-v2 change the defaultEngines records to have a single field for default/defaultPrivate matches. r=mcheang
https://hg.mozilla.org/integration/autoland/rev/85d549eafb17
Remove unnecessary additionalProperties requirement in search-config-v2-schema. r=mcheang

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4bda3f55164a
https://hg.mozilla.org/mozilla-central/rev/85d549eafb17