1870760 - After installing the proxy extension, restarting Fenix and entering the extension management keeps loading.

Status: RESOLVED FIXED

(Fenix :: WebExtensions, defect, P2)

Description

[lindongbin]

Attachment: 631b67523b2926d2fdde9bd6c1f093a2.jpeg

Steps to reproduce:

1.Install any proxy extension such as:
https://addons.mozilla.org/zh-CN/firefox/addon/foxyproxy-standard/
https://addons.mozilla.org/zh-CN/firefox/addon/smartproxy/
https://addons.mozilla.org/zh-CN/firefox/addon/switchyomega/
https://addons.mozilla.org/zh-CN/firefox/addon/proxy-toggle/

2.Completely exit fenix with no opened tab, re-open fenix, click the three dots in the lower right corner, "Add-ons"

Actual results:

As shown in the picture, it keeps loading.

Expected results:

Show add-ons list

Comment 1

[lindongbin]

This bug is reproducible on 123.0a1

Comment 2

[eclaudiu64]

Can you take a look?

Comment 3

[William Durand [:willdurand]]

Thanks, I'll take a look.

Comment 4

[William Durand [:willdurand]]

I can easily reproduce on Release.

:lindongbin does the list load if you open a new tab first after re-opening fenix?

Comment 5

[lindongbin]

(In reply to William Durand [:willdurand] from comment #4)

I can easily reproduce on Release.

:lindongbin does the list load if you open a new tab first after re-opening fenix?

Yes, open any website first, then open the add-ons and the list will load normally

Comment 6

[jackyzy823]

Pretty weird. If there's one tab open, the addon manager will show normally.

It looks like all loadicon requests created , but no response until timeout (about 5mins) and then addon manager will show but with default addon icons.

Maybe some bug with proxy under homepage ?

Comment 7

[jackyzy823]

Some update:

When no tab with proxy add-on installed , all requests created (client.fetch called ) but not send ( even no dns query found with tcpdump).

For example :
These requests created, but no dns query

https://contile.services.mozilla.com/v1/tiles
https://incoming.telemetry.mozilla.org/submit/org-mozilla-fenix-debug/metrics/1/xxxxxxx
https://addons.mozilla.org/user-media/addon_icons/607/607454-64.png?modified=mcrushed

Comment 8

[William Durand [:willdurand]]

Yeah, that's because proxy add-ons are only started when their background pages are started, and for that, we need a gecko session. A tab creates one. In other words, without any tab, we do not have a gecko session. Without a gecko session, extension background pages are not started. Without proxy extension background pages, requests (including "system" requests) are pending.

Comment 9

[jackyzy823]

Thanks for explanation!

That's quite a design issue. ( I always don't like the idea of homepage/newtab is not actual tab )

Comment 10

[Tom25519]

I suffering this bug today. I install add-on accidentally by touch "+" in add-on manager, then I exit Fenix, after enter add-on manager again, it keeps loading.

Comment 11

[Tom25519]

(In reply to Tom25519 from comment #10)

I suffering this bug today. I install add-on accidentally by touch "+" in add-on manager, then I exit Fenix, after enter add-on manager again, it keeps loading.

Thank goodness, I reinstall Fenix without uninstall or clear app data, it return to.normal.

Comment 12

[jackyzy823]

(In reply to Tom25519 from comment #11)

(In reply to Tom25519 from comment #10)

I suffering this bug today. I install add-on accidentally by touch "+" in add-on manager, then I exit Fenix, after enter add-on manager again, it keeps loading.

Thank goodness, I reinstall Fenix without uninstall or clear app data, it return to.normal.

You don't need to reinstall acutally.

You can 1. either wait about 5mins to let it timeout 2. go back to homepage , and open a tab, then go to add-on manager again.

Comment 13

[Rob Wu [:robwu]]

Attachment: Bug 1870760 - Start background upon receiving a proxy request

Startup of extension's background script is currently delayed until
after "browser-delayed-startup-finished". On desktop, this notification
is sent as soon as any browser window has been painted, which is usually
soon enough.

On Android, this notification is sent from geckoview.xhtml, which is
only loaded when any Gecko-hosted (web) content is shown. Network
requests can already be triggered from elsewhere (GeckoView) without
having loaded any Gecko-hosted "browser window" (geckoview.xhtml). This
is a problem when a proxy.onRequest handler has been registered,
because this can result in a request blocked indefinitely, as long as
the user has not opened an unrelated browser window.

To get around this problem, allow proxy request listeners to immediately
wake up the background page, on Android.

Comment 14

[Rob Wu [:robwu]]

Attachment: Bug 1870760 - Extra test case to verify that non-proxy events are not affected

The extensions.webextensions.early_background_wakeup_on_request pref
is currently only implemented for the proxy.onRequest event. This
extra test case verifies that a non-proxy event does not trigger the
early background startup (even with the pref), and that triggering
proxy.onRequest after that does trigger early background startup.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/feeabb9006d9
Start background upon receiving a proxy request r=rpl,geckoview-reviewers,zmckenney

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/feeabb9006d9

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:robwu, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfb56a59dd11
Extra test case to verify that non-proxy events are not affected r=rpl

Comment 19

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bfb56a59dd11