1870803 - Consider adding a transition for window activeness changes.

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1870803 - Add a transition on window activeness changes. r=dao

Now that we transition opacity and background-color, both of which are
accelerated in the compositor, we could do this, which makes activeness
changes a bit less jarring IMO.

Happy to just not take this if you think it's not worth it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/debea7fc7220
Add a transition on window activeness changes. r=dao,desktop-theme-reviewers

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_startup_flicker.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/b29631c4e1fcce563839d21c9e12da8a7f3b3d56
Log link: https://treeherder.mozilla.org/logviewer?job_id=440702883&repo=autoland&lineNumber=4985

Please check also this failure on browser_ext_management.js

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1870803 - Remove backgroundColorSetOnRoot from theming tests. r=#extension-reviewers,#theme

Win7/8 isn't supported anymore.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1870803 - Fix theme tests to ignore a potentially ongoing transition. r=#theme,#extension-reviewers

Depends on D196861

Comment 6

[Emilio Cobos Álvarez (:emilio)]

.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de49c708e005
Remove backgroundColorSetOnRoot from theming tests. r=desktop-theme-reviewers,dao

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1870803 - Fix browser perf tests to account for inactive window transition. r=dao

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b50326daf412
Fix theme tests to ignore a potentially ongoing transition. r=desktop-theme-reviewers,extension-reviewers,dao,rpl

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31eaa2b1cf1b
Fix browser perf tests to account for inactive window transition. r=dao

Comment 11

[Cristina Horotan [:chorotan]]

Backed out changeset 31eaa2b1cf1b (bug 1870803) on request by emilio

Backout: https://hg.mozilla.org/integration/autoland/rev/bfde20cdac84a12c9689e592235256910c333227

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=31eaa2b1cf1b61e0b8868c53cf6bdbfc14805942

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/de49c708e005
https://hg.mozilla.org/mozilla-central/rev/b50326daf412

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1870803 - Fix another test that I missed. r=dao

Depends on D196877

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8742ad55dec
Fix another test that I missed. r=dao

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f8742ad55dec

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e6ea4abfa49
Fix browser perf tests to account for inactive window transition. r=dao

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/343e9cda85e8
Add a transition on window activeness changes. r=dao,desktop-theme-reviewers

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37892207de28
Ignore the focus switch transition in browser_windowclose.js

Comment 19

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7e6ea4abfa49
https://hg.mozilla.org/mozilla-central/rev/343e9cda85e8
https://hg.mozilla.org/mozilla-central/rev/37892207de28