1870805 - The Review Checker Onboarding card does not shrink enough on MacOS with DE builds

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: ONboarding.png

Found in

• Nightly 123.0a1 (2023-12-18)

Affected versions

• Nightly 123.0a1 (2023-12-18)
• Beta 122.0b1

Affected platforms

• MacOS
• This Issue affects Window as well but its a less noticeable issue there.

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 0
Have a DE build.

Steps to reproduce

1. Reach Amazon.com/p
2. Select the first available item in order to reach the product details page.
3. Resize the Review Checker to the smallest size

Expected result

• The Onboarding card text should move on the next rows when resized to the smallest size.

Actual result

• The Onboarding card shrinks a bit but the text is still not fully visible after resizing it to the smallest size.
  Please note that En-US and FR builds do not have this issue, (On those versions it was fixed with Bug 1866501 )

Regression range
N/A

Comment 1

[Rares Doghi, Desktop QA]

Please also notice the X close button is also truncated when the Review Checker has the smallest size. Should we log a separate issue for it ?

Comment 2

[Jason Prickett]

Attachment: Bug 1870805 - Allow shopping onboarding container to scroll when extra-long words extend it r?#omc-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6463c7ed091
Allow shopping onboarding container to scroll when extra-long words extend it r=omc-reviewers,aminomancer

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d6463c7ed091

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jprickett, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Rares Doghi, Desktop QA]

Hi @jprickett, I tried to verify the fix in our latest Nightly build: 20240117092715 and the issue still occurs on MacOS as well as Windows, can you please take a look ?

Comment 7

[Rares Doghi, Desktop QA]

Attachment: MacScreen.png

Comment 8

[Jason Prickett]

@rdoghi The fix that product suggested is to add vertical scroll to this element when there is overflow due to an extra-long word. That seems to be the behavior upon my testing. Is that the behavior you see as well?

Comment 9

[Rares Doghi, Desktop QA]

Yes, that is how it works now, thank you for confirming, I will update the flags. Also I think you meant Horizontal scrollbar that shows up when the review checker has the smallest size.