1870809 - The dialog window shown after the OpenPGP key submission has wrong size

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Bogomil Shopov[:Bogomil]]

Attachment: Screenshot_20231219_125930.png

How to reproduce:

• Menu
• Tools
• OpenPGP Key Manager
• Select one of the keys
• Then click on the "Key Server" menu
• then click publish

I see the success result dialogue, but the "Close " button is cut. See the screenshot. I see this on 115 and on 122

Comment 1

[Magnus Melin [:mkmelin]]

Which exact version of 122 are you using?

Comment 2

[Bogomil Shopov[:Bogomil]]

Hi,
Sorry my bad, it's on 123.0a1 (2023-12-19), but I see the same on 115.* as well

Comment 3

[Magnus Melin [:mkmelin]]

I see that with both versions yes. But only for the first time the dialog is opened, and it seems to depend on how long the text is as well.

var { EnigmailDialog } = ChromeUtils.import("chrome://openpgp/content/modules/dialog.jsm");
EnigmailDialog.alert(null, "Public key sent to \"vks://keys.opengpgp.org\".");

Anyway, I literally have patches lined up for landing to use standard dialogs for this instead, which will avoid this issue...

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1870809 - Workaround to ensure OpenPGP alerts have some minimum size. r=#thunderbird-reviewers

This is a workaround really intended for 115 only. The code in question is getting removed, and fixing the sizing issues is difficult without completely rewriting the html...

Comment 5

[Bogomil Shopov[:Bogomil]]

Thanks Magnus!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3fe32769e8a4
Workaround to ensure OpenPGP alerts have some minimum size. r=aleca

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9369608 [details]
Bug 1870809 - Workaround to ensure OpenPGP alerts have some minimum size. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: bad UI in some openpgp alerts
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9369608 [details]
Bug 1870809 - Workaround to ensure OpenPGP alerts have some minimum size. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 122.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/800ca93fb18e

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9369608 [details]
Bug 1870809 - Workaround to ensure OpenPGP alerts have some minimum size. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 115.7.0:
https://hg.mozilla.org/releases/comm-esr115/rev/769f55c8eb54