1870812 - Add CSS_REGISTERED_PROPERTIES resource

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Since custom properties are tied to a given document it makes sense to have them as resources

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1870812 - [devtools] Add CSS_REGISTERED_PROPERTIES resource. r=#devtools-reviewers.

Depends on D196847

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Emilio, Zach, I'm adding an event listener on StyleSheetApplicableStateChanged¹ where the callback calls InspectorUtils.getCSSRegisteredProperties to retrieve the registered properties added in the stylesheet, but in some cases, it looks like the property aren't registered yet (at least on MacOS on TRY: https://treeherder.mozilla.org/logviewer?job_id=442251180&repo=try&lineNumber=4808-4849).
If I wait ~10ms then I do get the registered properties from the new stylesheet, but I'd rather avoid waiting for some arbitrary duration (just waiting for next tick isn't enough).

Is this something expected, and if so, would you have something in mind so we could fix it?

---

¹ we might have similar issue with StyleSheetRemoved, not sure though

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Yes. Change this code to call UpdateStylistIfNeeded.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Yes. Change this code to call UpdateStylistIfNeeded.

thanks, TV jobs are happy with this change now :)

Comment 5

[Zach Hoffman [:zrhoffman]]

Glad it's working!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41fd454b843a
[devtools] Add CSS_REGISTERED_PROPERTIES resource. r=devtools-reviewers,ochameau.

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_resources_css_registered_properties.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/51b98756f6743eddca1808415f27a517ae1a9abb

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=41fd454b843afb783ff9d4fcd89a0918d9033f86&selectedTaskRun=JFYNtOsGRieEGXuNLjDlSg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=443711475&repo=autoland&lineNumber=27969

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

ah yes, need to handle no eft

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8913eab3409d
[devtools] Add CSS_REGISTERED_PROPERTIES resource. r=devtools-reviewers,ochameau.

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/8913eab3409d