1870853 - [wpt-sync] Sync PR 43726 - Clone and update multicol fragments properly when adding OOFs.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43726 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43726
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Clone and update multicol fragments properly when adding OOFs.

If the original inner multicol container had descendant multicols with
pending OOFs, make sure that the cloned and updated multicol also
reflects this state.

For that to work, we also need to allow more OOF descendant propagation
when cloning and updating fragmentainers via SimplifiedLayoutAlgorithm.
Remove the disable_oof_descendants_propagation_ flag, and instead block
such propagation for OOF fragments that are inside a fragmentainer. Such
fragments are special, and the propagation is handled manually in
OutOfFlowLayoutPart::AddOOFToFragmentainer(). All other fragments should
propagate normally.

Bug: 1501713
Change-Id: Ib56750bb63a0d0894eef4d2979d24b93bdf9a761

Reviewed-on: https://chromium-review.googlesource.com/5134653
WPT-Export-Revision: e5b9df286d29235f8d9a8c5b176ebc27e9791285

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=812949fa72b2e93c84f1119becafd62fd7a8b7d0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6094f64dd2f
[wpt PR 43726] - Clone and update multicol fragments properly when adding OOFs., a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4c4c2a0c205
[wpt PR 43726] - Clone and update multicol fragments properly when adding OOFs., a=testonly

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f4c4c2a0c205