1870880 - Add "isInstance" assertion method to Assert.sys.mjs

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Alexandra Borovova [:Sasha]]

Follow-up from review: https://phabricator.services.mozilla.com/D196740#inline-1093389. Might be useful to add isInstance assertion method to Assert.sys.mjs to validate if an asserted argument is an instance of a certain class. It should be used only for classes which have isInstance method implemented, and this method should be used for assertion.

Comment 1

[gravyant]

I'll submit a patch for this bug soon.

Comment 2

[gravyant]

Attachment: WIP: Bug 1870880 - Add isInstance assertion method to Assert.sys.mjs

Comment 3

[gravyant]

Hi @Sasha, could you please take a look at the WIP patch I submitted and let me know if I'm taking the right approach and/or what I need to change?

Also, are there specific tests that you would like me to run?

Comment 4

[Alexandra Borovova [:Sasha]]

(In reply to gravyant from comment #3)

Hi @Sasha, could you please take a look at the WIP patch I submitted and let me know if I'm taking the right approach and/or what I need to change?

Also, are there specific tests that you would like me to run?

Hi! Thanks for the patch! I've replied to all your questions in the revision (including the testing).

Comment 5

[gravyant]

Attachment: Bug 1870880 - Add isInstance assertion method to Assert.sys.mjs. r?sasha

Comment 6

[gravyant]

Thanks, I revised my patch! Let me know if there are any other changes you'd like!

Comment 7

[Alexandra Borovova [:Sasha]]

(In reply to gravyant from comment #6)

Thanks, I revised my patch! Let me know if there are any other changes you'd like!

Great! I've added a comment

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6242594ba63
Add isInstance assertion method to Assert.sys.mjs. r=Sasha,webdriver-reviewers

Comment 9

[gravyant]

Thanks again, :sasha. Are there any JS bugs you recommend I take on next?

Comment 10

[Alexandra Borovova [:Sasha]]

(In reply to gravyant from comment #9)

Thanks again, :sasha. Are there any JS bugs you recommend I take on next?

I can suggest for example this one: https://bugzilla.mozilla.org/show_bug.cgi?id=1860812. Let me know if you have any questions.

Comment 11

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/e6242594ba63