1870906 - Refactor nsGridContainerFrame::ComputeSelfSubgridMasonryBits()

Status: RESOLVED FIXED

(Core :: Layout: Grid, task)

Description

[Daniel Holbert [:dholbert]]

Filing this bug for some supporting refactoring to prepare for bug 1800563's fix.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1870906 part 2: Split out a helper function to determine whether we should inhibit a grid from being a subgrid. r?TYLin

This patch doesn't change behavior; it's just refactoring out some
existing checks into a helper function.

Depends on D196900

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1870906 part 1: Simplify ComputeSelfSubgridMasonryBits() to return early once we know we can't be a subgrid. r?TYLin

This patch doesn't change behavior.

The code that follows the new early-return is all in the service of making
changes to the return value bits; and all of the modifications are guarded
directly or indirectly by checks for !inhibitSubgrid. So we might as well
just morph this inhibitSubgrid variable into an early-return and skip all of
that code entirely when it evaluates to true.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/482dff4d6dbe
part 1: Simplify ComputeSelfSubgridMasonryBits() to return early once we know we can't be a subgrid. r=TYLin,emilio
https://hg.mozilla.org/integration/autoland/rev/038afa747b43
part 2: Split out a helper function to determine whether we should inhibit a grid from being a subgrid. r=TYLin

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/482dff4d6dbe
https://hg.mozilla.org/mozilla-central/rev/038afa747b43