Closed Bug 1870930 Opened 11 months ago Closed 10 months ago

Remove obsolete registerFactoryLocation calls from cZ

Categories

(SeaMonkey :: Chat, enhancement)

enhancement

Tracking

(seamonkey2.53? affected)

RESOLVED FIXED
Tracking Status
seamonkey2.53 ? affected

People

(Reporter: frg, Assigned: frg)

Details

(Whiteboard: SM2.53.19)

Attachments

(1 file)

There is a call to registerFactoryLocation from Ci.nsIComponentRegistrar) in cZ which is long gone from the tree and we do not need to support ancient versions with the inlined copy.

1 * registerFactoryLocation
72 * @status OBSOLETE: This method is no longer implemented, but preserved
73 * in this interface for binary compatibility with
74 * Mozilla 1.9.2.

I wonder if the other command line stuff couldn't go too because xulrunner is gone but this would be for a different bug.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: useless code
Testing completed (on m-c, etc.): 2.53.19b1pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Attachment #9369541 - Flags: review?(iannbugzilla)
Attachment #9369541 - Flags: approval-comm-release?

Comment on attachment 9369541 [details] [diff] [review]
1870930-czclean-25319.patch

[Triage Comment]
LGTM r/a=me

Attachment #9369541 - Flags: review?(iannbugzilla)
Attachment #9369541 - Flags: review+
Attachment #9369541 - Flags: approval-comm-release?
Attachment #9369541 - Flags: approval-comm-release+

https://hg.mozilla.org/comm-central/rev/dd2a1fe4db244711356e748bb08c0e796cdd6a6f
Remove obsolete registerFactoryLocation calls from cZ. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: