1870978 - Open link from extensions causing history leak in private browsing mode in Fenix

Status: RESOLVED DUPLICATE of bug 1699444

(Firefox for Android :: WebExtensions, defect, P3)

Description

[Tom25519]

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:120.0) Gecko/120.0 Firefox/120.0

Steps to reproduce:

1.Into private browsing mode
2.Open a webpage
3.Touch "Report Site Issue..." in 3-dots menu, and a new page will open

Actual results:

History item appears, it even still existing after restart firefox.

Expected results:

Shouldn't leave any history (or others browsing data) in private browsing mode.

Comment 1

[Tom25519]

Same situation happens on uBlock Origin. Today, I report uBlock Origin filter issues, the private tab created by uBlock Origin also leaves history items.

Comment 2

[Claudiu]

I can reproduce this problem. Can you take a look?

Comment 3

[jackyzy823]

Ref:

1. https://searchfox.org/mozilla-mobile/source/firefox-android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/webextension/GeckoWebExtension.kt#258-267

GeckoEngineSession is instantiated with privateMode's default value false.

So no matter the tab is opened bu private tab or normal tab, this tab will always be normal (although it is in the private tabstray)

I add privateMode = true, , then the history item will not be generated.

2. If you take FirefoxReality as a refer:
   https://searchfox.org/mozilla-mobile/source/FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/browser/components/GeckoWebExtension.kt#250-253

it will create session based on activesession's private mode.

Comment 4

[Tom25519]

More strangely, today I login mailbox and mozilla bugzilla, after I quit fenix and reopen, then open theses websites, they're still logged in.

Comment 5

[Tom25519]

(In reply to Tom25519 from comment #4)

More strangely, today I login mailbox and mozilla bugzilla, after I quit fenix and reopen, then open theses websites, they're still logged in.

This situation only happens on Fennec F-droid 121.0, but not Fenix 121.0

Comment 6

[Tom25519]

(In reply to Tom25519 from comment #5)

(In reply to Tom25519 from comment #4)

More strangely, today I login mailbox and mozilla bugzilla, after I quit fenix and reopen, then open theses websites, they're still logged in.

This situation only happens on Fennec F-droid 121.0, but not Fenix 121.0

Today it happen on both Fenix 121.0.1 and F-droid 121.0.

Comment 7

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:amejia, could you have a look please?

For more information, please visit BugBot documentation.

Comment 11

[Shawn Zivontsis]

Similar issue: in private browsing, use the "Search by Image" extension to search for an image in a private tab. Click some links on the results page, and those links will be saved in your history even though they visually appear to be in private tabs. You will also be logged in to all services (e.g. Google) as if it were a non-private tab.

Comment 12

[killercontact1.7.4.0]

Tested against Fenix Nightly 141.0a1 (Build #2016096794).

I could not confirm the behaviour with the Report Broken Site button, from private mode I tapped "Send more info" from the Broken Site screen, which resulted in a private tab without a trace in normal browsing history.

However, comment #11 is reproducible. All cookies are present from normal browsing mode, the browsing history contains the pages involved.

Comment 13

[Rob Wu [:robwu]]

The "Report Site Issue" was fixed by bug 1940541, which replaced the built-in extension with mobile-native UI (called "Report broken site").

I'll fix comment 11 in a separate bug.