1871007 - The whole tab strip becomes transparent when the window is not focused if the title bar is not drawn in

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

[Affected versions]:

• Firefox Nightly 123.0a1, BuildID 20231219231600
• Firefox Beta 122.0b1, BuildID 20231218153201

[Affected Platforms]:

• Windows 10 22H2
• macOS 14.1.1
• Ubuntu 22.04

[Prerequisites]:

• Have the browser.tabs.inTitlebar pref set to 2.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a few tabs in the current window.
3. Open a new window and observe the previous one's tab strip.

[Expected result]:

• The tab strip is clearly visible.

[Actual result]:

• The tab strip is transparent and pinned tabs, favicons, and tab titles are harder to make out.

[Regression Window]:
8:59.65 INFO: Last good revision: ab5e2f241728caa5dc020e829b1045df55247758
8:59.65 INFO: First bad revision: 80d2ca5e4bece1bfb30ea95421c0c410c822b835
8:59.65 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ab5e2f241728caa5dc020e829b1045df55247758&tochange=80d2ca5e4bece1bfb30ea95421c0c410c822b835

[Notes]:

• The issue is not reproducible on Linux by default as we draw in the title bar.
• The issue is not reproducible on Windows and macOS when browser.tabs.inTitlebar is set to 2
• Attached is a screen recording of the issue: link

@emilio, could you please take a look at this?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1870100

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I'm confused, that is the intended effect of that change. Before only the text color changed, now we also fade favicons and other things in the titlebar.

I might be missing something tho, because I'm confused about your notes:

The issue is not reproducible on Linux by default as we draw in the title bar.

The default on Linux nowadays is the same as other platforms.

The issue is not reproducible on Windows and macOS when browser.tabs.inTitlebar is set to 2

Isn't that contradictory with the prerequisite?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Please reopen if I'm missing something

Comment 4

[Ciprian Muresan [:cmuresan], Ecosystem QA]

The Linux thing was a slip-up on my part, I was still under the impression that we still had the title bar separate and I didn't even notice that this was not the case when I checked on Ubuntu.

The reason I filed the ticket was because the issue that I came across was tagged with Linux and the screen recording from there was with the title bar enabled. I had assumed that this was an unintended side effect from when we do draw in the title bar.

Thanks for checking it out and for confirmation that it was intended. Sorry for the noise.