1871019 - The invalid webextension telemetry is incorrectly reported for search engines with post data

Status: RESOLVED FIXED

(Firefox :: Search, defect, P3)

Description

[Mark Banner (:standard8)]

I noticed that a couple of weeks ago there was a bump in telemetry where some add-on installed search engines were showing as having parameters that didn't match the installed add-on.

On investigation, it appears that an add-on incorrectly set search_url_post_params and later reverted it. However, we shouldn't have reported issues as the parameters should have been updated correctly.

Looking at the code, we are doing an equality match on two objects, which is wrong as they are created separately.

What we should be doing is a match against the data - existingSubmission.postData.data.data == newSubmission.postData.data.data.

We should fix that and add some tests to test_webextensions_valid.js that check post data based add-ons.

I suspect this won't affect the telemetry counts much, as search engines using post parameters are quite rare, however it would still be good to fix to get more accurate data.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1871019 - Fix telemetry reporting about search engines not matching the installed WebExtension when using post parameters. r?#search-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b9e88e5e216
Fix telemetry reporting about search engines not matching the installed WebExtension when using post parameters. r=search-reviewers,daleharvey

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6b9e88e5e216