1871033 - [wpt-sync] Sync PR 43744 - Notify the flow thread about style change for inlines as well.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43744 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43744
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Notify the flow thread about style change for inlines as well.

We only did it for LayoutBox or better, but this is necessary for
LayoutInline as well.

When a layout object changes whether or not it's a containing block for
out-of-flow positioned descendants, the multicol flow thread machinery
may need to insert or remove LayoutMultiColumnSet objects - since
ouf-of-flow positioned descendants may become part of (or cease to be
part of) the multicol container because such a change.

This is detected in NeedsToReinsertIntoFlowThread().

Move the flow thread hooks in StyleWillChange() and StyleDidChange()
from LayoutBox to LayoutBoxModelObject, so that this also works for
inlines.

This was most likely a LayoutNG regression, since the legacy engine
didn't really let inlines act as containing blocks.

Bug: 1503298
Change-Id: I7afcf447f8d81bd35cb1f049d04c7cdae3d3abf1
Reviewed-on: https://chromium-review.googlesource.com/5137017
WPT-Export-Revision: b734fc5aed1620718084fcc5191b0999683774e8

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8965edab3f1d4d3125ef5931f78d817c867fba8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48d31b069193
[wpt PR 43744] - Notify the flow thread about style change for inlines as well., a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9a109502bd0
[wpt PR 43744] - Notify the flow thread about style change for inlines as well., a=testonly

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f9a109502bd0