1871053 - [wpt-sync] Sync PR 43748 - Use LayoutObject style for OOFCandidateStyleIterator

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43748 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43748
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Use LayoutObject style for OOFCandidateStyleIterator

The LayoutObject style is the right one to use for layout purposes. It
differs from the Element style in some cases. In particular, the
computed writing-mode of the body is propagated to the LayoutObject
style of the root element, but does not affect the computed value for
the root element.

This caused a DCHECK() failure when the constraint_space writing-mode
differed from the ComputedStyle used during layout.

Bug: 1512988
Change-Id: I0b25bd8a05556cbe84a5324ff8724836336ab1ea
Reviewed-on: https://chromium-review.googlesource.com/5139690
WPT-Export-Revision: 54a2fb10f67b72d34d677c987ae795d888a5416d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=053fb0c34af9e0f301f36af4ebe30b99ba1ce912

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80a0639b8473
[wpt PR 43748] - Use LayoutObject style for OOFCandidateStyleIterator, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/80a0639b8473