1871110 - IOUtils::ComputeHexDigestSync should drop sha1 support

Status: RESOLVED FIXED

(Toolkit Graveyard :: IOUtils and PathUtils, task, P3)

Description

[Dana Keeler (she/her) [:keeler]]

It doesn't look like anything is using sha1 with IOUtils::ComputeHexDigestSync, so we should remove that as an option.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1871110 - Remove sha1 support from IOUtils::ComputeHexDigest r?#xpcom-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1130670445e4
Remove sha1 support from IOUtils::ComputeHexDigest r=xpcom-reviewers,mccr8

Comment 3

[Cristian Tuns]

Backed out for causing mochitest failures in test_ioutils_compute_hex_digest.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/system/tests/ioutils/test_ioutils_compute_hex_digest.html | Test timed out. -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2d838cca6bd
Remove sha1 support from IOUtils::ComputeHexDigest r=xpcom-reviewers,mccr8

Comment 5

[Cristian Tuns]

Backed out for causing xpcshell failures in test_system_update_checkSizeHash.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_system_update_checkSizeHash.js | xpcshell return code: 0

Comment 6

[Beth Rennie [:beth] (she/her)]

This is still used in https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/test_system_update_checkSizeHash.js. I need to investigate if we can replace those instances with sha256 or similar.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:barret, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 8

[Beth Rennie [:beth] (she/her)]

I have validated that the test that failed can be updated to use a different hash function. Additionally, all addons served by balrog use sha512 as the hash function.

Comment 9

[Christoph Kerschbaumer [:ckerschb, back on Aug 10th}]

Hey Barret, I see you already made good progress on this patch. I suppose you are busy with lots of things though I wanted to check if you are still on it? (It's not super time critical, though I am reaching out to all the folks in my deprecate-hashes-bug-queue at the moment). Thank you.

Comment 10

[Beth Rennie [:beth] (she/her)]

Sorry this slipped off my radar. I'll try to update the patch and have it landed this week. Thanks for the reminder!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6c57c28bd7d
Remove sha1 support from IOUtils::ComputeHexDigest r=xpcom-reviewers,mccr8,extension-reviewers,robwu

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b6c57c28bd7d