Closed Bug 1871116 Opened 10 months ago Closed 9 months ago

[wpt-sync] Sync PR 43759 - [A11y] Partial revert to fix crash when finding <option> parent

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox123 fixed)

Status:
RESOLVED FIXED
Milestone:
123 Branch
Tracking Flags:
Tracking Status
firefox123 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43759 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43759
Details from upstream follow.

Aaron Leventhal <aleventhal@google.com> wrote:

[A11y] Partial revert to fix crash when finding <option> parent

Partial revert of CL:5123413. Remove NOTREACHED() and restore comment.

This condition is rare, but can occur if a \<select> is inside of a
\<details> element. When the \<select> is first created, there is
no layout object, and a generic AXObject (not AXMenuList) is
created. The autofill code can call in just at the right time to
request this parent, and hits the NOTREACHED().

Test: this crash occurs when loading clock.laplace.live, or by loading the included test in the browser. It's unclear why, but the test does
not crash when running as a web test.

Note that these AXMenuList* classes will be going away in favor
of a generic implementation based on the shadow DOM, using ordinary
AXNodeObjects.

Fixed: 1512999
Change-Id: I318d6198abc7b155e42030caf00f039c7b09e4ac

Reviewed-on: https://chromium-review.googlesource.com/5141647
WPT-Export-Revision: 30acf42b87c6d4e74b035851b59f30429e3cd6ed

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0acb6188b340 [wpt PR 43759] - [A11y] Partial revert to fix crash when finding <option> parent, a=testonly
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d253a1778f3 [wpt PR 43759] - [A11y] Partial revert to fix crash when finding <option> parent, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/8d253a1778f3

Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox123: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.