1871195 - [wpt-sync] Sync PR 43765 - Try fixing the type confusion with DOM Parts

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43765 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43765
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Try fixing the type confusion with DOM Parts

Fixed: 1510578
Change-Id: Ie18901857a4b089265185c3efdabfb5448da2e46
Reviewed-on: https://chromium-review.googlesource.com/5142457
WPT-Export-Revision: a63e7aa7596b3c9acab89d451aaebc5d3def2b7b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d45dad3e5d2524e8402e0a6750530cd61c338971

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

OK : 1
FAIL : 16
ERROR: 1

Chrome

OK : 1
PASS : 16
CRASH: 1

Safari

OK : 1
FAIL : 16
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /dom/parts/basic-dom-part-objects.tentative.html [wpt.fyi]
  • Basic imperative DOM Parts object construction (Document): FAIL (Chrome: PASS, Safari: FAIL)
  • Cloning (Document): FAIL (Chrome: PASS, Safari: FAIL)
  • Cloning Element (Document): FAIL (Chrome: PASS, Safari: FAIL)
  • Cloning Text (Document): FAIL (Chrome: PASS, Safari: FAIL)
  • Cloning Comment (Document): FAIL (Chrome: PASS, Safari: FAIL)
  • DOM mutations are not tracked (Document): FAIL (Chrome: PASS, Safari: FAIL)
  • ChildNodePart children manipulation (Document): FAIL (Chrome: PASS, Safari: FAIL)
  • Corner case ChildNodePart construction and cloning (Document): FAIL (Chrome: PASS, Safari: FAIL)
  • Basic imperative DOM Parts object construction (DocumentFragment): FAIL (Chrome: PASS, Safari: FAIL)
  • Cloning (DocumentFragment): FAIL (Chrome: PASS, Safari: FAIL)
  • Cloning Element (DocumentFragment): FAIL (Chrome: PASS, Safari: FAIL)
  • Cloning Text (DocumentFragment): FAIL (Chrome: PASS, Safari: FAIL)
  • Cloning Comment (DocumentFragment): FAIL (Chrome: PASS, Safari: FAIL)
  • DOM mutations are not tracked (DocumentFragment): FAIL (Chrome: PASS, Safari: FAIL)
  • ChildNodePart children manipulation (DocumentFragment): FAIL (Chrome: PASS, Safari: FAIL)
  • Corner case ChildNodePart construction and cloning (DocumentFragment): FAIL (Chrome: PASS, Safari: FAIL)
• /dom/parts/dom-parts-valid-node-types.tentative.html [wpt.fyi]: ERROR (Chrome: CRASH, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa728bfcc78c
[wpt PR 43765] - Disallow invalid node types in DOM Parts API constructors, a=testonly
https://hg.mozilla.org/integration/autoland/rev/6f95441d5ffd
[wpt PR 43765] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fa728bfcc78c
https://hg.mozilla.org/mozilla-central/rev/6f95441d5ffd