Closed Bug 1871377 Opened 11 months ago Closed 5 months ago

Fetch KeepAlive - Block parent actor termination if child actor terminates due to page unload

Categories

(Core :: DOM: Networking, enhancement, P2)

Product:
Core
Component:
DOM: Networking
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: smayya, Assigned: smayya)

References

Details

(Whiteboard: [necko-triaged], [wptsync upstream])

Attachments

(1 file)

Bug 1871377 - block FetchParent from cancelling fetch operation during shutdown for keepalive requests. r=#necko,edenchuang,asuth
48 bytes, text/x-phabricator-request
Details | Review

In our current design for keepalive, we need to block termination of the PFetch Parent actor if the child actor terminates due to page unload.

Whiteboard: [necko-triaged]
Severity: -- → N/A
Priority: -- → P2
Assignee: nobody → smayya
Attachment #9397361 - Attachment description: WIP: Bug 1871377 - block FetchParent from cancelling fetch operation during shutdown for keepalive requests. r=#necko → Bug 1871377 - block FetchParent from cancelling fetch operation during shutdown for keepalive requests. r=#necko,edenchuang,asuth
Pushed by smayya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b2f28e905212 block FetchParent from cancelling fetch operation during shutdown for keepalive requests. r=edenchuang,necko-reviewers,jesup

Backed out for causing bp-nu bustages related to RefPtr.h and wpt failures related to "attribute keepalive".

[task 2024-06-10T20:18:51.660Z] 20:18:51     INFO -  dom/clients/manager/ClientSourceChild.o
[task 2024-06-10T20:18:51.662Z] 20:18:51     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.204Z] 20:18:52     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.209Z] 20:18:52     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o ClientSourceChild.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/clients/manager -I/builds/worker/workspace/obj-build/dom/clients/manager -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/ClientSourceChild.o.pp   /builds/worker/checkouts/gecko/dom/clients/manager/ClientSourceChild.cpp
[task 2024-06-10T20:18:52.210Z] 20:18:52     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.212Z] 20:18:52     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.214Z] 20:18:52     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.215Z] 20:18:52     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.216Z] 20:18:52     INFO -  dom/clients/manager/ClientSourceOpChild.o
[task 2024-06-10T20:18:52.217Z] 20:18:52     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.828Z] 20:18:52     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.831Z] 20:18:52     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o ClientSourceOpChild.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/clients/manager -I/builds/worker/workspace/obj-build/dom/clients/manager -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/ClientSourceOpChild.o.pp   /builds/worker/checkouts/gecko/dom/clients/manager/ClientSourceOpChild.cpp
[task 2024-06-10T20:18:52.831Z] 20:18:52     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.838Z] 20:18:52     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.839Z] 20:18:52     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.843Z] 20:18:52     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:52.844Z] 20:18:52     INFO -  dom/clients/manager/ClientSourceOpParent.o
[task 2024-06-10T20:18:52.844Z] 20:18:52     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:53.393Z] 20:18:53     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:53.395Z] 20:18:53     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o ClientSourceOpParent.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/clients/manager -I/builds/worker/workspace/obj-build/dom/clients/manager -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/ClientSourceOpParent.o.pp   /builds/worker/checkouts/gecko/dom/clients/manager/ClientSourceOpParent.cpp
[task 2024-06-10T20:18:53.396Z] 20:18:53     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:53.397Z] 20:18:53     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:53.398Z] 20:18:53     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:53.400Z] 20:18:53     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:53.400Z] 20:18:53     INFO -  dom/clients/manager/ClientSourceParent.o
[task 2024-06-10T20:18:53.401Z] 20:18:53     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/clients/manager'
[task 2024-06-10T20:18:54.632Z] 20:18:54     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/fetch'
[task 2024-06-10T20:18:54.635Z] 20:18:54     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o FetchChild.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/fetch -I/builds/worker/workspace/obj-build/dom/fetch -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/protocol/data -I/builds/worker/checkouts/gecko/netwerk/protocol/http -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/FetchChild.o.pp   /builds/worker/checkouts/gecko/dom/fetch/FetchChild.cpp
[task 2024-06-10T20:18:54.636Z] 20:18:54     INFO -  In file included from /builds/worker/checkouts/gecko/dom/fetch/FetchChild.cpp:5:
[task 2024-06-10T20:18:54.637Z] 20:18:54     INFO -  In file included from /builds/worker/checkouts/gecko/dom/fetch/FetchChild.h:8:
[task 2024-06-10T20:18:54.638Z] 20:18:54     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/AbortSignal.h:10:
[task 2024-06-10T20:18:54.638Z] 20:18:54    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:48:37: error: member access into incomplete type 'mozilla::dom::Document'
[task 2024-06-10T20:18:54.639Z] 20:18:54     INFO -     48 |   static void AddRef(U* aPtr) { aPtr->AddRef(); }
[task 2024-06-10T20:18:54.640Z] 20:18:54     INFO -        |                                     ^
[task 2024-06-10T20:18:54.640Z] 20:18:54     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:408:61: note: in instantiation of member function 'mozilla::RefPtrTraits<mozilla::dom::Document>::AddRef' requested here
[task 2024-06-10T20:18:54.641Z] 20:18:54     INFO -    408 |     static void AddRef(U* aPtr) { mozilla::RefPtrTraits<U>::AddRef(aPtr); }
[task 2024-06-10T20:18:54.642Z] 20:18:54     INFO -        |                                                             ^
[task 2024-06-10T20:18:54.642Z] 20:18:54     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:108:37: note: in instantiation of member function 'RefPtr<mozilla::dom::Document>::ConstRemovingRefPtrTraits<mozilla::dom::Document>::AddRef' requested here
[task 2024-06-10T20:18:54.643Z] 20:18:54     INFO -    108 |       ConstRemovingRefPtrTraits<T>::AddRef(mRawPtr);
[task 2024-06-10T20:18:54.644Z] 20:18:54     INFO -        |                                     ^
[task 2024-06-10T20:18:54.645Z] 20:18:54     INFO -  /builds/worker/checkouts/gecko/dom/fetch/FetchChild.cpp:178:30: note: in instantiation of member function 'RefPtr<mozilla::dom::Document>::RefPtr' requested here
[task 2024-06-10T20:18:54.646Z] 20:18:54     INFO -    178 |       RefPtr<Document> doc = window->GetExtantDoc();
[task 2024-06-10T20:18:54.646Z] 20:18:54     INFO -        |                              ^
[task 2024-06-10T20:18:54.647Z] 20:18:54     INFO -  /builds/worker/workspace/obj-build/dist/include/imgIContainer.h:23:7: note: forward declaration of 'mozilla::dom::Document'
[task 2024-06-10T20:18:54.648Z] 20:18:54     INFO -     23 | class Document; /* webidl Document */
[task 2024-06-10T20:18:54.649Z] 20:18:54     INFO -        |       ^
[task 2024-06-10T20:18:54.649Z] 20:18:54     INFO -  In file included from /builds/worker/checkouts/gecko/dom/fetch/FetchChild.cpp:5:
[task 2024-06-10T20:18:54.650Z] 20:18:54     INFO -  In file included from /builds/worker/checkouts/gecko/dom/fetch/FetchChild.h:8:
[task 2024-06-10T20:18:54.651Z] 20:18:54     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/mozilla/dom/AbortSignal.h:10:
[task 2024-06-10T20:18:54.652Z] 20:18:54    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:49:38: error: member access into incomplete type 'mozilla::dom::Document'
[task 2024-06-10T20:18:54.653Z] 20:18:54     INFO -     49 |   static void Release(U* aPtr) { aPtr->Release(); }
[task 2024-06-10T20:18:54.653Z] 20:18:54     INFO -        |                                      ^
[task 2024-06-10T20:18:54.654Z] 20:18:54     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:409:62: note: in instantiation of member function 'mozilla::RefPtrTraits<mozilla::dom::Document>::Release' requested here
[task 2024-06-10T20:18:54.655Z] 20:18:54     INFO -    409 |     static void Release(U* aPtr) { mozilla::RefPtrTraits<U>::Release(aPtr); }
[task 2024-06-10T20:18:54.656Z] 20:18:54     INFO -        |                                                              ^
[task 2024-06-10T20:18:54.656Z] 20:18:54     INFO -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:80:37: note: in instantiation of member function 'RefPtr<mozilla::dom::Document>::ConstRemovingRefPtrTraits<mozilla::dom::Document>::Release' requested here
[task 2024-06-10T20:18:54.657Z] 20:18:54     INFO -     80 |       ConstRemovingRefPtrTraits<T>::Release(mRawPtr);
[task 2024-06-10T20:18:54.658Z] 20:18:54     INFO -        |                                     ^
[task 2024-06-10T20:18:54.659Z] 20:18:54     INFO -  /builds/worker/checkouts/gecko/dom/fetch/FetchChild.cpp:178:30: note: in instantiation of member function 'RefPtr<mozilla::dom::Document>::~RefPtr' requested here
[task 2024-06-10T20:18:54.659Z] 20:18:54     INFO -    178 |       RefPtr<Document> doc = window->GetExtantDoc();
[task 2024-06-10T20:18:54.660Z] 20:18:54     INFO -        |                              ^
[task 2024-06-10T20:18:54.661Z] 20:18:54     INFO -  /builds/worker/workspace/obj-build/dist/include/imgIContainer.h:23:7: note: forward declaration of 'mozilla::dom::Document'
[task 2024-06-10T20:18:54.662Z] 20:18:54     INFO -     23 | class Document; /* webidl Document */
[task 2024-06-10T20:18:54.663Z] 20:18:54     INFO -        |       ^
[task 2024-06-10T20:18:54.663Z] 20:18:54     INFO -  2 errors generated.
[task 2024-06-10T20:18:54.664Z] 20:18:54    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:689: FetchChild.o] Error 1
[task 2024-06-10T20:18:54.665Z] 20:18:54     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/fetch'
[task 2024-06-10T20:18:54.665Z] 20:18:54     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/fetch'
[task 2024-06-10T20:18:54.665Z] 20:18:54     INFO -  dom/fetch/FetchDriver.o
[task 2024-06-10T20:18:54.665Z] 20:18:54     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/fetch'
[task 2024-06-10T20:18:56.126Z] 20:18:56     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/docshell/base'
[task 2024-06-10T20:18:56.129Z] 20:18:56     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -o CanonicalBrowsingContext.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/docshell/base -I/builds/worker/workspace/obj-build/docshell/base -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/docshell/shistory -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/dom/bindings -I/builds/worker/checkouts/gecko/js/xpconnect/src -I/builds/worker/checkouts/gecko/layout/base -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/style -I/builds/worker/checkouts/gecko/layout/xul -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/protocol/viewsource -I/builds/worker/checkouts/gecko/toolkit/components/browser -I/builds/worker/checkouts/gecko/toolkit/components/find -I/builds/worker/checkouts/gecko/tools/profiler -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -D_GLIBCXX_USE_CXX11_ABI=0 -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/CanonicalBrowsingContext.o.pp   /builds/worker/checkouts/gecko/docshell/base/CanonicalBrowsingContext.cpp
[task 2024-06-10T20:18:56.131Z] 20:18:56     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/docshell/base'
[task 2024-06-10T20:18:56.131Z] 20:18:56     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/docshell/base'
[task 2024-06-10T20:18:56.132Z] 20:18:56     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/docshell/base'
[task 2024-06-10T20:18:56.135Z] 20:18:56     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/docshell/base'
[task 2024-06-10T20:18:56.136Z] 20:18:56     INFO -  docshell/base/ChildProcessChannelListener.o
Flags: needinfo?(smayya)
Flags: needinfo?(smayya)
Pushed by smayya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f40672b20c47 block FetchParent from cancelling fetch operation during shutdown for keepalive requests. r=edenchuang,necko-reviewers,jesup

Backed out 3 changesets (bug 1871377, bug 1871376) for causing multiple failures on FetchChild.cpp.
All the failures occurred on Linux 18.04 x64 WebRender asan opt.

Flags: needinfo?(smayya)
Whiteboard: [necko-triaged] → [necko-triaged], [wptsync upstream]
Pushed by smayya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b65593e993b block FetchParent from cancelling fetch operation during shutdown for keepalive requests. r=edenchuang,necko-reviewers,jesup
Flags: needinfo?(smayya)

https://hg.mozilla.org/mozilla-central/rev/0b65593e993b

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
Regressions: 1902560
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: