Closed Bug 1871395 Opened 2 years ago Closed 1 year ago

Implement Pref for configuring Resource Limits for fetch keepalive.

Categories

(Core :: DOM: Networking, enhancement, P2)

Product:
Core
Component:
DOM: Networking
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox131 --- fixed

People

(Reporter: smayya, Assigned: smayya)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1871395 - add pref for keepalive resource limits. r=#necko
48 bytes, text/x-phabricator-request
Details | Review

We need to provide a flexible way of configuring the resource limits for requests with keepalive. One way of doing this could be putting the following resource limits under a pref:

  • Number of pending Fetch requests with keepalive flag per origin.
  • Number of pending Fetch requests with keepalive flag per instance of the parent process.
Severity: -- → N/A
Priority: -- → P2
Whiteboard: [necko-triaged]
Assignee: nobody → smayya
Attachment #9412538 - Attachment description: WIP: Bug 1871395 - add pref for keepalive resource limits → WIP: Bug 1871395 - add pref for keepalive resource limits. r=#necko
Status: NEW → ASSIGNED
Attachment #9412538 - Attachment description: WIP: Bug 1871395 - add pref for keepalive resource limits. r=#necko → Bug 1871395 - add pref for keepalive resource limits. r=#necko
Pushed by smayya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8b75d052771e add pref for keepalive resource limits. r=necko-reviewers,kershaw

Backed out for causing wpt failures on request-keepalive-quota.html

[task 2024-08-07T22:04:54.101Z] 22:04:54     INFO - TEST-START | /_mozilla/fetch/api/request/request-keepalive-quota.html?include=keepalive-request-limit-per-origin-2
[task 2024-08-07T22:04:54.108Z] 22:04:54     INFO - Closing window 879bae24-92d3-4919-a220-ccd30332e9ea
[task 2024-08-07T22:04:54.161Z] 22:04:54     INFO - Closing window 6c7995fa-b491-4eb4-b3ba-4202f49a4d4d
[task 2024-08-07T22:04:54.379Z] 22:04:54     INFO - 
[task 2024-08-07T22:04:54.380Z] 22:04:54     INFO - TEST-UNEXPECTED-FAIL | /_mozilla/fetch/api/request/request-keepalive-quota.html?include=keepalive-request-limit-per-origin-2 | A Keep-Alive fetch() per origin quota should become available after pending requests are completed. - promise_test: Unhandled rejection with value: "A Keep-Alive fetch() request exceeding per origin limit should reject."
[task 2024-08-07T22:04:54.380Z] 22:04:54     INFO - TEST-OK | /_mozilla/fetch/api/request/request-keepalive-quota.html?include=keepalive-request-limit-per-origin-2 | took 280ms
[task 2024-08-07T22:04:54.383Z] 22:04:54     INFO - PID 10180 | 1723068294381	Marionette	INFO	Stopped listening on port 55799
[task 2024-08-07T22:04:55.171Z] 22:04:55     INFO - Browser exited with return code 0
[task 2024-08-07T22:04:55.174Z] 22:04:55     INFO - Closing logging queue
[task 2024-08-07T22:04:55.175Z] 22:04:55     INFO - queue closed
[task 2024-08-07T22:04:55.234Z] 22:04:55     INFO - Application command: D:\task_172306337666578\build\application\firefox\firefox.exe -marionette about:blank --wait-for-browser -profile C:\Users\task_172306337666578\AppData\Local\Temp\tmp5t_h7i7a
[task 2024-08-07T22:04:55.246Z] 22:04:55     INFO - PID 5252 | 1723068286433	Marionette	INFO	Marionette enabled
[task 2024-08-07T22:04:55.247Z] 22:04:55     INFO - PID 5252 | 1723068286547	Marionette	INFO	Listening on port 55811
[task 2024-08-07T22:04:55.248Z] 22:04:55     INFO - PID 5252 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-07T22:04:55.250Z] 22:04:55     INFO - PID 5252 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error for Amo: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-08-07T22:04:55.250Z] 22:04:55     INFO - PID 5252 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-07T22:04:55.252Z] 22:04:55     INFO - PID 5252 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error for Amp: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-08-07T22:04:55.252Z] 22:04:55     INFO - PID 5252 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-07T22:04:55.253Z] 22:04:55     INFO - PID 5252 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error for Wikipedia: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-08-07T22:04:55.254Z] 22:04:55     INFO - PID 5252 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-07T22:04:55.255Z] 22:04:55     INFO - PID 5252 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error for Mdn: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-08-07T22:04:55.257Z] 22:04:55     INFO - PID 5252 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-07T22:04:55.258Z] 22:04:55     INFO - PID 5252 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error for Yelp: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-08-07T22:04:55.258Z] 22:04:55     INFO - Starting runner
[task 2024-08-07T22:04:56.607Z] 22:04:56     INFO - Installing extension from D:\task_172306337666578\build\tests\extensions\specialpowers@mozilla.org.xpi
[task 2024-08-07T22:04:56.845Z] 22:04:56     INFO - TEST-START | /_mozilla/fetch/api/request/request-keepalive-quota.html?include=keepalive-request-limit-per-origin-1
[task 2024-08-07T22:04:57.182Z] 22:04:57     INFO - 
[task 2024-08-07T22:04:57.183Z] 22:04:57     INFO - TEST-UNEXPECTED-FAIL | /_mozilla/fetch/api/request/request-keepalive-quota.html?include=keepalive-request-limit-per-origin-1 | Restrict the number of pending requests per origin to dom.fetchKeepalive.request_limit_per_origin - promise_test: Unhandled rejection with value: "A Keepalive fetch() should be rejected when per origin pending requests exceed the limit."
[task 2024-08-07T22:04:57.184Z] 22:04:57     INFO - TEST-OK | /_mozilla/fetch/api/request/request-keepalive-quota.html?include=keepalive-request-limit-per-origin-1 | took 337ms
[task 2024-08-07T22:04:57.185Z] 22:04:57     INFO - Restarting browser for new test group
[task 2024-08-07T22:04:57.187Z] 22:04:57     INFO - PID 5252 | 1723068297185	Marionette	INFO	Stopped listening on port 55811
[task 2024-08-07T22:04:58.072Z] 22:04:58     INFO - Browser exited with return code 0
[task 2024-08-07T22:04:58.077Z] 22:04:58     INFO - Closing logging queue
[task 2024-08-07T22:04:58.077Z] 22:04:58     INFO - queue closed
[task 2024-08-07T22:04:58.150Z] 22:04:58     INFO - Application command: D:\task_172306337666578\build\application\firefox\firefox.exe -marionette about:blank --wait-for-browser -profile C:\Users\task_172306337666578\AppData\Local\Temp\tmprmwt9coh
[task 2024-08-07T22:04:58.169Z] 22:04:58     INFO - PID 2616 | 1723068295799	Marionette	INFO	Marionette enabled
[task 2024-08-07T22:04:58.171Z] 22:04:58     INFO - PID 2616 | 1723068295913	Marionette	INFO	Listening on port 55840
[task 2024-08-07T22:04:58.171Z] 22:04:58     INFO - Starting runner
[task 2024-08-07T22:04:59.062Z] 22:04:59     INFO - PID 2616 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-07T22:04:59.071Z] 22:04:59     INFO - PID 2616 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error for Amo: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-08-07T22:04:59.076Z] 22:04:59     INFO - PID 2616 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-07T22:04:59.077Z] 22:04:59     INFO - PID 2616 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error for Amp: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-08-07T22:04:59.078Z] 22:04:59     INFO - PID 2616 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-07T22:04:59.080Z] 22:04:59     INFO - PID 2616 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error for Wikipedia: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-08-07T22:04:59.082Z] 22:04:59     INFO - PID 2616 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-07T22:04:59.084Z] 22:04:59     INFO - PID 2616 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error for Mdn: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-08-07T22:04:59.085Z] 22:04:59     INFO - PID 2616 | [ERROR error_support::handling] suggest-unexpected: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base
[task 2024-08-07T22:04:59.086Z] 22:04:59     INFO - PID 2616 | console.error: URLBar - QuickSuggest.SuggestBackendRust: "Ingest error for Yelp: Error from Remote Settings: Error parsing URL: relative URL with a cannot-be-a-base base"
[task 2024-08-07T22:04:59.803Z] 22:04:59     INFO - Installing extension from D:\task_172306337666578\build\tests\extensions\specialpowers@mozilla.org.xpi
[task 2024-08-07T22:05:00.029Z] 22:05:00     INFO - TEST-START | /_mozilla/mathml/mathml-console-messages.html
Flags: needinfo?(smayya)
Flags: needinfo?(smayya)
Pushed by smayya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce5d81092522 add pref for keepalive resource limits. r=necko-reviewers,kershaw

https://hg.mozilla.org/mozilla-central/rev/ce5d81092522

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: