1871441 - Core DLP code should calculate file digests if necessary

Status: RESOLVED FIXED

(Firefox :: Data Loss Prevention, task, P2)

Description

[Greg Stoll :gstoll]

This would make it easier on calling code, because the calling code is often on the main thread and we shouldn't be doing file I/O on the main thread.

Comment 1

[Greg Stoll :gstoll]

Attachment: Bug 1871441 - calcuate digest in content analysis code if caller does not r=handyman

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97aee1542e79
calcuate digest in content analysis code if caller does not r=handyman

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/97aee1542e79

Comment 4

[Greg Stoll :gstoll]

Attachment: Bug 1871441 - small fixes to ContentAnalysisRequest::GetFileDigest() r=rkraesig,handyman

Use a bigger buffer for reading file contents, and use MOZ_DIAGNOSTIC_ASSERT to make sure we're not doing file IO on the main thread.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9343b9b9d52e
small fixes to ContentAnalysisRequest::GetFileDigest() r=rkraesig

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing hazard failure on analyze.py

Backout link

Push with failures

Failure log

Comment 7

[Greg Stoll :gstoll]

I was skeptical, but this looks like a "real" failure - it fails consistently with my change and succeeds without it. :sfink is looking into why this seemingly-innocuous change caused this.

Comment 8

[Greg Stoll :gstoll]

The hazard analyzer problem is bug 1874510. I'm reworking this change slightly to avoid hitting it.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a271c737a80
small fixes to ContentAnalysisRequest::GetFileDigest() r=rkraesig

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7a271c737a80