1871458 - [mozrunner] On MacOS don't use "Contents/MacOS/firefox-bin" binary as default but read the executable from the Info.plist

Status: RESOLVED FIXED

(Testing :: Mozbase Rust, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Originally reported as: https://github.com/mozilla/geckodriver/issues/2144

There is a regression in Firefox 121 (see bug 1871447) which doesn't allow Selenium and other clients to start Firefox anymore for a default installation of Firefox. While we need fixes in Firefox and also for Selenium we should make sure that geckodriver doesn't default to this binary as well:

https://searchfox.org/mozilla-central/rev/b580e3f77470b2337bc8ae032b58a85c11e66aba/testing/mozbase/rust/mozrunner/src/runner.rs#409-433

Also we probably have to check if some WebDriver client actually specified firefox-bin as binary capability, and refuse or update it.

This currently blocks a couple of CI jobs running via Selenium.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1871458 - [mozrunner-rust] Don't default to "firefox-bin" but use executable from application bundle.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The problem here with Selenium will happen when test suites and other automation clients consuming Selenium as API are using the old Firefox binary helper classes to find the default installation. With the new Selenium Manager this problem does not exist because it's using the right firefox binary.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/450a8c4d7913
[mozrunner-rust] Don't default to "firefox-bin" but use executable from application bundle. r=glandium

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/450a8c4d7913