1871472 - Update MinGW to support `RoGetAgileReference` and remove workarounds

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Ray Kraesig [:rkraesig]]

MinGW doesn't know how to link ::RoGetAgileReference, and will need to be patched to do so.

Once that's done, the workaround added in bug 1869053 (in ipc/mscom/AgileReference.cpp) can be removed.

Comment 1

[Biswapriyo Nath [:biswa96]]

Attachment: Bug 1871472: Remove mingw workaround for RoGetAgileReference function r=tjr

The workaround was added in https://phabricator.services.mozilla.com/D196364
The function was added in https://sourceforge.net/p/mingw-w64/mingw-w64/ci/da103349b968320aeeb55322cba1ac897319e963/

Comment 2

[Tom Ritter [:tjr]]

Thanks, will look at this after the holiday weekend and we've completed our release tagging/branch merging.

Comment 3

[Tom Ritter [:tjr]]

Sent in a try build here https://treeherder.mozilla.org/jobs?repo=try&revision=c802f73898e17ade3d247d78fb3756f09791e3f8 to double check

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ae190326a0f1
https://hg.mozilla.org/integration/autoland/rev/b6237a68b144
Remove mingw workaround for RoGetAgileReference function r=tjr

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b6237a68b144