Closed
Bug 1871472
Opened 1 year ago
Closed 5 months ago
Update MinGW to support `RoGetAgileReference` and remove workarounds
Categories
(Firefox Build System :: General, task)
Tracking
(firefox141 fixed)
RESOLVED
FIXED
141 Branch
| Tracking | Status | |
|---|---|---|
| firefox141 | --- | fixed |
People
(Reporter: rkraesig, Assigned: biswa96)
Details
Attachments
(1 file)
MinGW doesn't know how to link ::RoGetAgileReference, and will need to be patched to do so.
Once that's done, the workaround added in bug 1869053 (in ipc/mscom/AgileReference.cpp) can be removed.
|
Assignee | |
Comment 1•5 months ago
|
||
The workaround was added in https://phabricator.services.mozilla.com/D196364
The function was added in https://sourceforge.net/p/mingw-w64/mingw-w64/ci/da103349b968320aeeb55322cba1ac897319e963/
|
||
Updated•5 months ago
|
Assignee: nobody → nathbappai
Status: NEW → ASSIGNED
|
||
Comment 2•5 months ago
|
||
Thanks, will look at this after the holiday weekend and we've completed our release tagging/branch merging.
|
|
||
Comment 3•5 months ago
|
||
Sent in a try build here https://treeherder.mozilla.org/jobs?repo=try&revision=c802f73898e17ade3d247d78fb3756f09791e3f8 to double check
Pushed by tritter@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/ae190326a0f1
https://hg.mozilla.org/integration/autoland/rev/b6237a68b144
Remove mingw workaround for RoGetAgileReference function r=tjr
|
||
Comment 5•5 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox141:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•