1871512 - Add telemetry to distinguish whether C++ or JS `do-task` implementation was run

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, task)

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1871512 - Add telemetry to differentiate whether Default Agent's do-task used JavaScript of C++ implementation. r=mhughes

Comment 2

[Nick Rishel [:nrishel]]

Comment on attachment 9370453 [details]
Bug 1871512 - Add telemetry to differentiate whether Default Agent's do-task used JavaScript of C++ implementation. r=mhughes

DATA REVIEW REQUEST

1. What questions will you answer with this data?

Whether a Nimbus rollback is successful if we ever need to trigger it.

2. Why does Mozilla need to answer these questions? Are there benefits for users?
   Do we need this information to address product or business requirements?

We need this to have confidence that if we trigger a rollback, it took place. This guards against needing a point release (user annoyance) if we find anomalous behavior in release.

3. What alternative methods did you consider to answer these questions?
   Why were they not sufficient?

We could rely on inferring that a rollback succeeded by other telemetry returning to normal. In the past this has been an involved process due to telemetry relying on OS context that can change out from under us.

4. Can current instrumentation answer these questions?

Through inference, which has historically been a source of significant uncertainty.

5. List all proposed measurements and indicate the category of data collection for each
   measurement, using the Firefox data collection categories found on the Mozilla wiki.

Measurement Name	Measurement Description	Data Collection Category	Tracking Bug
do_task.implementation	Which implementation of do-task was used: "JavaScript" by default or "C++" if a Nimbus rollback was acted upon.	Technical data	https://bugzilla.mozilla.org/show_bug.cgi?id=1871512

6. Please provide a link to the documentation for this data collection which
   describes the ultimate data set in a public, complete, and accurate way.

This collection is Glean so is documented in the Glean Dictionary.

7. How long will this data be collected?

This collection has expiry '124'.

8. What populations will you measure?

All channels, countries, and locales. No filters.

9. If this data collection is default on, what is the opt-out mechanism for users?

Opt-out relies on previously existing mechanisms for the default agent.

10. Please provide a general description of how you will analyze this data.

If we need to trigger a rollback via nimbus, we will inspect the data to verify it trends from "JavaScript" to "C++".

11. Where do you intend to share the results of your analysis?

If we trigger a rollback, it will likely be shared in an incident report. Otherwise the data is unlikely to be analyzed other than to verify it's reporting as expected.

12. Is there a third-party tool (i.e. not Glean or Telemetry) that you
    are proposing to use for this data collection?

No.

Comment 3

[klong]

Comment on attachment 9370453 [details]
Bug 1871512 - Add telemetry to differentiate whether Default Agent's do-task used JavaScript of C++ implementation. r=mhughes

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, this collection is Glean so is documented in the Glean Dictionary. https://dictionary.telemetry.mozilla.org/

Is there a control mechanism that allows the user to turn the data collection on and off?

This telemetry is a Firefox Background Task which uses a profile separate from the normal user profile so the normal Glean user opt out does not work. However, the relevant background task has pre-existing opt out mechanism that was previously approved.

If the request is for permanent data collection, is there someone who will monitor the data over time?

This collection has expiry '124'.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1 (Technical)

Is the data collection request for default-on or default-off?

Yes, default on for all visitors (All channels, countries, and locales. No filters.)

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/755ed1318d2f
Add telemetry to differentiate whether Default Agent's do-task used JavaScript of C++ implementation. r=mhughes

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/755ed1318d2f