1871540 - Use VariableValue to track dependencies in non-custom properties.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871540 - Move WebVTT default font-size/writing-mode workaround to videocontrols.css. r=dshin

This allows moving the custom properties outside of the UA stylesheets.

Ideally these variables wouldn't be needed and the cue pseudo would
behave more like ::part(), but for now this does the trick and allows
the following patch to work.

I'll look into simplifying this a bit more.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871540 - Use VariableValue to track references in unparsed values. r=dshin,#style,#layout

Depends on D197146

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a066a966cd03
Move WebVTT default font-size/writing-mode workaround to videocontrols.css. r=dshin,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/6d2274dc2f41
Use VariableValue to track references in unparsed values. r=dshin

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871540 - Fix an inspector assertion when inspecting ::cue pseudos. r=dshin

I noticed that we weren't finding the :host::cue rule in the inspector,
even though it was applying and working.

When we're a NAC pseudo-element, also look at the relevant shadow root.

Could probably write a test for this, but I think I want to make the
setup for ::cue (which is the only weird pseudo like this) a bit nicer,
so not sure it's worth it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d1bc9b657a7
Fix an inspector assertion when inspecting ::cue pseudos. r=dshin

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing webvtt related failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=web%2Creftest&revision=576e61e3970b803be63455fa2dc84a5eb0642be4&selectedTaskRun=bzOiR8wDTPupZw116C_MeA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=441173213&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/b3e9fcc4a96c958b07c6936393778980c9dde1fb

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdd2bb7464c9
Move WebVTT default font-size/writing-mode workaround to videocontrols.css. r=dshin,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/9eb78117bef2
Use VariableValue to track references in unparsed values. r=dshin

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/cdd2bb7464c9
https://hg.mozilla.org/mozilla-central/rev/9eb78117bef2

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7d1bc9b657a7

Comment 10

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d1bc9b657a7
Fix an inspector assertion when inspecting ::cue pseudos. r=dshin

== Change summary for alert #40852 (as of Fri, 05 Jan 2024 08:49:39 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
11%	motionmark-animometer-ramp	windows10-64-shippable-qr	fission webrender	608.21 -> 677.30	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40852

Comment 11

[Emilio Cobos Álvarez (:emilio)]

That can't be right, that only affects DevTools code.

Comment 12

[Andra Esanu (needinfo me)]

Thank you for the confirmation.