Closed Bug 1871745 Opened 4 months ago Closed 4 months ago

Inputs styled with "-moz-user-focus: none" is no longer focusable

Categories

(Core :: DOM: Core & HTML, defect)

Firefox 122
All
Unspecified
defect

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox121 --- unaffected
firefox122 + fixed
firefox123 + fixed

People

(Reporter: sunhaitao, Assigned: emilio)

References

(Regression)

Details

(Keywords: dev-doc-complete, regression)

Attachments

(4 files)

Attached file demo.html

Gecko 122 no longer allows inputs styled with "-moz-user-focus: none" to be focused. Since some websites (such as https://www.decathlon.com.cn/) still set this for unknown reasons, this change will create some compatible problems.

Such sites are functional on Gecko 120. The attached file named "demo.html" can be used to demonstrate the behavior difference.

Keywords: regression
Regressed by: 1868552

Set release status flags based on info from the regressing bug 1868552

:emilio, since you are the author of the regressor, bug 1868552, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

So... what's the right way of checking the new use counter data? https://mozilla.github.io/usecounters/ doesn't show newer use-counter data. (I'd ask :chutten but requests blocked :)).

In any case, depending on the use counter data, we can take a few approaches:

  • If it's really low, CSS compat intervention would do.
  • Otherwise, hiding this property from content is probably better.

For now I requested sheriffs to back out the regressing patch from beta, for now.

Flags: needinfo?(emilio) → needinfo?(alessio.placitelli)

-moz-user-focus: none didn't do anything useful for non-XUL until
bug 1868552. It seems nonetheless some sites specify it, which can cause
compat issues.

Let's hide this property from content, to avoid breaking those sites.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65525b63d6cf
Hide -moz-user-focus from content. r=smaug

Backed out for causing bc failures on browser_bug462289.js, browser_PanelMultiView_focus.js

Backout link

Push with failures

Failure log 1 // Failure log 2

Flags: needinfo?(emilio)

So that chrome code can keep setting -moz-user-focus via script, for
example.

Flags: needinfo?(emilio)
Attached file Requested diff.
Flags: needinfo?(peterv)

Setting 122 to fixed, the regressor was backed out of beta

Flags: needinfo?(peterv)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/619b6b3dfcfe
Hide -moz-user-focus from content. r=smaug
https://hg.mozilla.org/integration/autoland/rev/659e4e834582
Keep exposing chrome-only properties on CSS2Properties. r=peterv
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

So... what's the right way of checking the new use counter data? https://mozilla.github.io/usecounters/ doesn't show newer use-counter data. (I'd ask :chutten but requests blocked :)).

To my knowledge the new data is still pending validation, so I'd hesitate to recommend using it until we get greenlight from Chris (who is now back). See bug 1866834 for the most recent updates on the topic.

Flags: needinfo?(alessio.placitelli)

MDN docs for this can be tracked in https://github.com/mdn/content/issues/31928.

My understanding is that from the website developer perspective, the change will appear to be that the -moz-user-focus (and associated property values) has been removed from Firefox in FF123. Is that correct, or is the existence of this property still useful to anyone outside of firefox development?

If so, then would the right change be to record this as removed in BCD and mark https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-user-focus as deprecated?

Flags: needinfo?(emilio)

That sounds about right.

Flags: needinfo?(emilio)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: