1871762 - Developer Tools: Network status bar is misplaced after switching tabs

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Sviatoslav Abakumov [:Perlence]]

Attachment: 2023-12-23_22-20-21.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

1. Open the Developer Tools
2. Click on the Network tab
3. Click on a request, the request details sidebar opens
4. Click any other Developer Tools tab, e.g. Debugger
5. Click on the Network tab again

Actual results:

The status bar of the request table moves up, see the screenshot.

Expected results:

The status bar stays at the bottom of the request table.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Netmonitor' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Thanks for the report, I can indeed reproduce

This is caused by https://searchfox.org/mozilla-central/rev/24ea2579c4a94d5da8db4bb529cbefe5e5e3c2d3/devtools/client/netmonitor/src/components/request-list/RequestListContent.js#180-188

/*
 * Removing onResize() method causes perf regression - too many repaints of the panel.
 * So it is needed in ComponentDidMount and ComponentDidUpdate. See Bug 1532914.
 */
onResize() {
  const parent = this.refs.scrollEl.parentNode;
  this.refs.scrollEl.style.width = parent.offsetWidth + "px";
  this.refs.scrollEl.style.height = parent.offsetHeight + "px";
}

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

I can't reproduce on ESR 115

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Bug 1451717 caused this issue to appear, but it may just be that we used to benefit from an erroneous behavior before.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1451717

:emilio, since you are the author of the regressor, bug 1451717, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871762 - Remove RequestListContent.onResize(). r=nchevobbe

I don't think this should be slower than what you're doing nowadays. If
for some reason we do need this, it should use a resize observer on the
container, not listen to the window resize event.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1451717

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1871762 - [devtools] Wait for request animation frame to resize netmonitor request list

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecfbe60ac0e3
[devtools] Wait for request animation frame to resize netmonitor request list r=devtools-reviewers,ochameau

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ecfbe60ac0e3