1871766 - New wpt crashes in /css/css-content/parsing/content-computed.html

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 43782 found new crashes in CI

Affected Tests

• /css/css-content/parsing/content-computed.html [wpt.fyi]: CRASH

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

Getting the crash signature into these bug reports is a TODO; sorry

These updates will be on mozilla-central once bug 1871692 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Daniel Holbert [:dholbert]]

From the try run in the bug that imported this test and annotated it as expected-to-crash, the crash here is actually Firefox refusing to load a remote URI:

[task 2023-12-23T20:02:40.321Z] 20:02:40     INFO - PID 7532 | FATAL ERROR: Non-local network connections are disabled and a connection attempt to www.example.com (93.184.216.34) was made.
[task 2023-12-23T20:02:40.322Z] 20:02:40     INFO - PID 7532 | You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.
[task 2023-12-23T20:02:40.666Z] 20:02:40     INFO - PID 7532 | Exiting due to channel error.
[task 2023-12-23T20:02:40.667Z] 20:02:40     INFO - IOError on command, setting status to CRASH
[task 2023-12-23T20:02:40.669Z] 20:02:40     INFO - mozcrash Downloading symbols from: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/L16bbJeuRfaT83fF5rIs0g/artifacts/public/build/target.crashreporter-symbols.zip
[task 2023-12-23T20:03:23.303Z] 20:03:23     INFO - mozcrash Copy/paste: Z:\task_170336125218024\fetches\minidump-stackwalk\minidump-stackwalk.exe --symbols-url=https://symbols.mozilla.org/ --cyborg=C:\Users\task_170336125218024\AppData\Local\Temp\tmpmyh6cm42\cc8b0395-4ca8-4d85-a0c1-353d5ba9fe5c.trace C:\Users\task_170336125218024\AppData\Local\Temp\tmpz_qvgi3h\minidumps\cc8b0395-4ca8-4d85-a0c1-353d5ba9fe5c.dmp C:\Users\task_170336125218024\AppData\Local\Temp\tmp653pa_2z
[task 2023-12-23T20:03:36.151Z] 20:03:36     INFO - mozcrash Saved minidump as Z:\task_170336125218024\build\blobber_upload_dir\cc8b0395-4ca8-4d85-a0c1-353d5ba9fe5c.dmp
[task 2023-12-23T20:03:36.155Z] 20:03:36     INFO - mozcrash Saved app info as Z:\task_170336125218024\build\blobber_upload_dir\cc8b0395-4ca8-4d85-a0c1-353d5ba9fe5c.extra
[task 2023-12-23T20:03:36.589Z] 20:03:36     INFO - PROCESS-CRASH | Attempting to connect to non-local address! opener is [unknown], uri is [https://www.example.com/picture.svg] [@ mozilla::net::nsHttpChannel::OnStartRequest] | /css/css-content/parsing/content-computed.html 
[task 2023-12-23T20:03:36.589Z] 20:03:36     INFO - Process type: main
[task 2023-12-23T20:03:36.589Z] 20:03:36     INFO - Process pid: 2896
[task 2023-12-23T20:03:36.589Z] 20:03:36     INFO - Mozilla crash reason: Attempting to connect to non-local address! opener is [unknown], uri is [https://www.example.com/picture.svg]

https://treeherder.mozilla.org/logviewer?job_id=441266810&repo=try&lineNumber=1346

So this is a bug in the test, and the test should be changed so as not to reference https://www.example.com/picture.svg

Comment 2

[Daniel Holbert [:dholbert]]

Alternately, we can add display:none to the <div id="target"> element so that it won't actually try to load its associated images, I think.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1871766: Fix WPT content-computed.html to not send actual image requests to example.com. r?#layout

This WPT puts CSS like the following on a test element:
content: url("https://www.example.com/picture.svg")

That is effecively equivalent to inserting an element like the following:
<img src="https://www.example.com/picture.svg">

In particular, it triggers an actual web request to example.com, in an attempt
to load the actual image. Firefox's test harness configuration detects this
remote network-request and insta-crashes instead of executing it, which is why
this test was flagged as crashing in Firefox. Really, the test needs to be
fixed to avoid generating this image request entirely.

So, this patch adds display:none to the target element, which is sufficient
to prevent the browser from loading images for that element. (This change
doesn't impact the behavior that the test is actually trying to exercise, which
is just parsing, not image loading and rendering.)

As part of this, I'm updating Firefox's in-tree test-failure annotations from
a crash to a pile of subtest-failures, which are all due to
https://bugzilla.mozilla.org/show_bug.cgi?id=1281158

Comment 4

[Daniel Holbert [:dholbert]]

Try: https://treeherder.mozilla.org/jobs?repo=try&revision=da32c19af75e4b421e044a12203b45d668f93aa8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f5a522f7bb2
Fix WPT content-computed.html to not send actual image requests to example.com. r=layout-reviewers,emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43963 for changes under testing/web-platform/tests

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1f5a522f7bb2

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot