Crash in [@ DMABufSurfaceRGBA::ReleaseTextures]
Categories
(Core :: Graphics, defect, P3)
Tracking
()
People
(Reporter: aosmond, Assigned: aosmond)
References
(Blocks 1 open bug)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
Crash report: https://crash-stats.mozilla.org/report/index/6f9d168f-dcf3-4330-a59b-2e2500231225
MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(mGL) (Missing GL context!)
Top 10 frames of crashing thread:
0 libxul.so DMABufSurfaceRGBA::ReleaseTextures widget/gtk/DMABufSurface.cpp:720
1 libxul.so DMABufSurfaceRGBA::ReleaseSurface widget/gtk/DMABufSurface.cpp:747
1 libxul.so DMABufSurfaceRGBA::~DMABufSurfaceRGBA widget/gtk/DMABufSurface.cpp:382
2 libxul.so DMABufSurfaceRGBA::~DMABufSurfaceRGBA widget/gtk/DMABufSurface.cpp:378
3 libxul.so mozilla::gl::SurfaceFactory_DMABUF::CreateSharedImpl gfx/gl/SharedSurfaceDMABUF.h:59
4 libxul.so mozilla::gl::SurfaceFactory::CreateShared gfx/gl/SharedSurface.h:187
5 libxul.so mozilla::gl::SwapChain::Acquire gfx/gl/GLScreenBuffer.cpp:54
6 libxul.so mozilla::WebGLContext::CopyToSwapChain dom/canvas/WebGLContext.cpp:1096
7 libxul.so mozilla::gfx::DrawTargetWebgl::CopyToSwapChain dom/canvas/DrawTargetWebgl.cpp:4680
7 libxul.so mozilla::layers::CanvasTranslator::UnlockTexture gfx/layers/ipc/CanvasTranslator.cpp:828
Assignee | ||
Comment 1•6 months ago
|
||
If the GL context MakeCurrent fails, then we can end up in a state where mEGLImage is valid, but there is no context:
https://searchfox.org/mozilla-central/rev/fc757816ed9d8f8552dbcb96c1f89f8108f37b2a/widget/gtk/DMABufSurface.cpp#692
https://searchfox.org/mozilla-central/rev/fc757816ed9d8f8552dbcb96c1f89f8108f37b2a/widget/gtk/DMABufSurface.cpp#1493
And when we release it, we can trip this assert:
https://searchfox.org/mozilla-central/rev/fc757816ed9d8f8552dbcb96c1f89f8108f37b2a/widget/gtk/DMABufSurface.cpp#720
https://searchfox.org/mozilla-central/rev/fc757816ed9d8f8552dbcb96c1f89f8108f37b2a/widget/gtk/DMABufSurface.cpp#1529
Assignee | ||
Comment 2•6 months ago
|
||
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3606ab5e28ab Ensure DMABUF calls MakeCurrent before creating EGLImage objects. r=gfx-reviewers,lsalzman
Updated•6 months ago
|
Comment 4•6 months ago
|
||
bugherder |
Updated•5 months ago
|
Description
•