1871863 - [GTK] Port from away from GdkCursorType to gdk_cursor_new_from_name

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jordan Petridis]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

adwaita-icon-theme, GNOME's and GTK's default icon theme dropped legacy X cursors recently [1] (expected to be released with GNOME 46) and thus, when running firefox some of the cursors are unable to be created and end up blank with a handful of gtk warnings.

The reason for this, is due to Firefox using the old GdkCursorType api which doesn't guarantee the cursors requested will exist. This is mostly legacy code from the gtk2 backend. gdk_cursor_new_from_name (from gtk3 and onwards) can create all the cursors firefox wants (and it's also using the same CSS3/4 conventions that firefox does intenrally). GdkCursorType has also been dropped in GTK 4 and this patch should help with porting the code too.

[1] https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/merge_requests/61

Actual results:

Dec 24 16:09:02 gnomeos firefox-bin[2863]: Unable to load left_ptr from the cursor theme
Dec 24 16:09:02 gnomeos firefox-bin[2863]: Unable to load xterm from the cursor theme
Dec 24 16:09:02 gnomeos firefox-bin[2863]: Unable to load left_ptr from the cursor theme
Dec 24 16:09:02 gnomeos firefox-bin[2863]: Unable to load left_ptr from the cursor theme
Dec 24 16:09:03 gnomeos firefox-bin[2863]: Unable to load xterm from the cursor theme

Expected results:

Cursor is working as usual

Comment 1

[Jordan Petridis]

Attachment: Bug 1871863 - Port from GdkCursorType to gdk_cursor_new_from_name. r?rmader

adwaita-icon-theme, GNOME's and GTK's default icon theme dropped
legacy X cursors recently [1] which is expected to be released with
GNOME 46. When running firefox now some of the cursors are unable to be
created and end up blank with a handful of gtk warnings.

The reason for this, is due to Firefox using the old GdkCursorType
api which doesn't guarantee the cursors requested will exist.
This is mostly legacy code from the gtk2 backend.
gdk_cursor_new_from_name (from gtk3 and onwards) can create all
the cursors firefox wants (and it's also using the same CSS3/4
conventions that firefox does intenrally).

GdkCursorType has also been dropped in GTK 4 and this patch should
help with porting the code too.

[1] https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/merge_requests/61

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Robert Mader [:rmader]]

I suppose we should backport this patch to ESR115?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c71d09ab8b2b
Port from GdkCursorType to gdk_cursor_new_from_name. r=rmader,stransky

Comment 5

[Jordan Petridis]

Yea, will be nice to get it into ESR after it's tested for a bit

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c71d09ab8b2b