Closed Bug 1871977 Opened 2 years ago Closed 2 years ago

Glean complains about non-main process string metric types but error messages are opaque

Categories

(Toolkit :: Telemetry, defect)

Product:
Toolkit
Component:
Telemetry
Version:
Firefox 123
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1872767

People

(Reporter: grgoffe, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

Just run FF nightly.

Actual results:

[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[fluent] Missing message in locale en-CA: main-context-menu-manage-passwords
[fluent] Missing message in locale en-CA: places-forget-domain-data
[fluent] Missing message in locale en-CA: menu-report-broken-site
[fluent] Missing message in locale en-CA: shopping-sidebar-open-button2
[fluent] Missing message in locale en-CA: toolbar-button-account
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[fluent] Missing message in locale en-CA: shopping-sidebar-open-button2
[fluent] Missing message in locale en-CA: toolbar-button-account
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[fluent] Missing message in locale en-CA: shopping-sidebar-open-button2
[fluent] Missing message in locale en-CA: toolbar-button-account
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[fluent] Missing message in locale en-CA: quickactions-cmd-savepdf
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[fluent] Missing message in locale en-CA: protections-panel-report-broken-site
[fluent] Missing message in locale en-CA: protections-panel-cookie-banner-blocker-header
[fluent] Missing message in locale en-CA: protections-panel-cookie-banner-blocker-view-title
[fluent] Missing message in locale en-CA: protections-panel-cookie-banner-blocker-view-turn-off-for-site
[fluent] Missing message in locale en-CA: protections-panel-cookie-banner-blocker-view-turn-on-for-site
[fluent] Missing message in locale en-CA: protections-panel-cookie-banner-blocker-view-turn-on-description
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[fluent] Missing message in locale en-CA: main-context-menu-manage-passwords
[fluent] Missing message in locale en-CA: places-forget-domain-data
[fluent] Missing message in locale en-CA: menu-report-broken-site
[fluent] Missing message in locale en-CA: shopping-sidebar-open-button2
[fluent] Missing message in locale en-CA: toolbar-button-account
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[fluent] Missing message in locale en-CA: shopping-sidebar-open-button2
[fluent] Missing message in locale en-CA: toolbar-button-account
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[fluent] Missing message in locale en-CA: shopping-sidebar-open-button2
[fluent] Missing message in locale en-CA: toolbar-button-account
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[fluent] Missing message in locale en-CA: quickactions-cmd-savepdf
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[fluent] Missing message in locale en-CA: main-context-menu-manage-passwords
[fluent] Missing message in locale en-CA: places-forget-domain-data
[fluent] Missing message in locale en-CA: menu-report-broken-site
[fluent] Missing message in locale en-CA: shopping-sidebar-open-button2
[fluent] Missing message in locale en-CA: toolbar-button-account
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[fluent] Missing message in locale en-CA: shopping-sidebar-open-button2
[fluent] Missing message in locale en-CA: toolbar-button-account
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[fluent] Missing message in locale en-CA: shopping-sidebar-open-button2
[fluent] Missing message in locale en-CA: toolbar-button-account
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[fluent] Missing message in locale en-CA: reset-pbm-toolbar-button
[fluent] Missing message in locale en-CA: quickactions-cmd-savepdf
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.
[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.

Expected results:

I believe that these messages depict the browser's reaction to error conditions... These error(s) need to be addressed.

The Bugbug bot thinks this bug should belong to the 'Firefox::Messaging System' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Messaging System

Hi flod, any idea what's going on with these errors?

Component: Messaging System → General
Flags: needinfo?(francesco.lodolo)

[fluent] Missing message in locale en-CA: *** are expected, because en-CA localization is not complete (it falls back to en-US and raises a warning in console).

For ´Unable to set string metric in non-main process.`, I think it needs someone more familiar with that specific code.

Flags: needinfo?(francesco.lodolo)

Moving to Telemetry as that's generating the:

[ERROR firefox_on_glean::private::string] Unable to set string metric in non-main process. Ignoring.

errors. I expect this will ultimately need addressing in the consumers, but from the error message it's impossible to determine what those are. That probably needs fixing in Telemetry/Glean code.

Component: General → Telemetry
Product: Firefox → Toolkit
Summary: strange messages appear during use of firefox-nightly → Glean complains about non-main process string metric types but error messages are opaque

This means someone added a string metric to non-parent processes and didn't notice in their testing (we did test it, right?) that it didn't work. The error's doing its best, as non-main-process metric instances are 0-size for performance, so it has no idea who it is. Maybe we could pack the name in for debug builds? Wouldn't help all that much if the instrumenting dev's not in the habit of looking at logs or testing their instrumentation, but it could help track things down post-facto like we're doing now.

I've skimmed the 80 or so string metrics in Firefox Desktop but nothing stands out as obvious. It's something that's hit a lot, whatever it is.

I've tried running a local build, but nothing errors out there. I wonder if it's something in official builds only... Nah, building with MOZ_OFFICIAL=1 doesn't help.

Does someone reading this bugmail have a build exhibiting this problem that they can breakpoint on toolkit/components/glean/api/src/private/string.rs#46? George, are you familiar with running a debugger?

Flags: needinfo?(grgoffe)

Oh wait, hey, this is bug 1872767. Should already be fixed!

Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1872767
Resolution: --- → DUPLICATE

Could we consider crashing on infra (ie if xpc::IsInAutomation() is true)? Then it'd cause tests to error and we'd get stacks immediately.

Flags: needinfo?(grgoffe) → needinfo?(chutten)

Sure could. How confident are we that xpc::IsInAutomation() is never true on a user's machine? checks ... Ohhh, this is the security.turn_off_all_security_so_that_viruses_can_take_over_this_computer pref? And it requires nonlocal connections disabled? Okay, yeah, this is pretty ironclad, isn't it.

Gonna hafta expose this to Rust. Probably go with something a la FOG_TooLateToSend. I've filed bug 1873661 to track this.

Thanks for the idea!

Flags: needinfo?(chutten)
You need to log in before you can comment on or make changes to this bug.