1872087 - Share recycled texture data across remote texture owners on a single client

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement)

Description

[Lee Salzman [:lsalzman]]

Some canvas use-cases like pdfpaint can create a bunch of canvases and then destroy them, which means we will fail to benefit from recycled texture speedups.

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1872087 - Share recycled texture data across remote texture owners on a single client. r?sotaro

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/856e86584c4c
Share recycled texture data across remote texture owners on a single client. r=sotaro,gfx-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/856e86584c4c

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1872087 - Share recycling across WebGL framebuffers on a single context. r?aosmond

This was a change for bug 1872087 that somehow got lost when I was rebasing. The idea
here is that DrawTargetWebgls use a single shared WebGL context, so it makes sense for
them to share recycle texture data, much like CanvasTranslator shares recycling of
texture data for D2D. This should increase the efficiency of use-cases that create and
destroy a lot of canvases every frame and would not normally benefit from recycling.

Depends on D197375

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c0ef884644c
Share recycling across WebGL framebuffers on a single context. r=aosmond,gfx-reviewers

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing gpu related leak failures

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e15b5318d54
Share recycling across WebGL framebuffers on a single context. r=aosmond,gfx-reviewers

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2e15b5318d54

Comment 9

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/856e86584c4c
Share recycled texture data across remote texture owners on a single client.
r=sotaro,gfx-reviewers

== Change summary for alert #40809 (as of Sat, 30 Dec 2023 05:01:35 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	motionmark-animometer	windows10-64-shippable-qr	fission webrender	42.98 -> 44.93

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40809