Closed Bug 1872116 Opened 5 months ago Closed 5 months ago

checkDateTimeString is too permissive

Categories

(Remote Protocol :: WebDriver BiDi, defect, P3)

defect

Tracking

(firefox123 fixed)

RESOLVED FIXED
123 Branch
Tracking Status
firefox123 --- fixed

People

(Reporter: vinny.diehl, Assigned: vinny.diehl)

References

Details

(Whiteboard: [webdriver:m10][webdriver:external][webdriver:relnote])

Attachments

(1 file)

We found a bug in this regex that allows non-standard dates through, e.g. "200009" (the last 2 digits being parsed as a month). This is fixed by wrapping the YYYY portion of the regex in a non-capturing group.

Assignee: nobody → vinny.diehl
Status: NEW → ASSIGNED
Attachment #9370326 - Attachment description: Bug 1872116 - Fix year detection in checkTimeDateString r?whimboo → Bug 1872116 - Fix year detection in checkTimeDateString r?whimboo,arai
Priority: -- → P3
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/7321a9549679
Fix year detection in checkTimeDateString r=whimboo,webdriver-reviewers,arai
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch

Vinny, thanks a lot for the fix which makes the check much better to understand.

Whiteboard: [webdriver:m10][webdriver:external]
Whiteboard: [webdriver:m10][webdriver:external] → [webdriver:m10][webdriver:external][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: