1872169 - Fenix ignores 'extensions.update.enabled'

Status: RESOLVED FIXED

(Firefox for Android :: WebExtensions, defect)

Description

[erosman [:erosman]]

It appears that Fenix ignores extensions.update.enabled which is needed for users who prefer to use older versions of extensions.

Comment 1

[William Durand [:willdurand] [OOO until Aug. 25]]

Attachment: Bug 1872169 - Honor `extensions.update.enabled` pref in GeckoView. r?amejiamarmol!,rpl!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0439e1b8489d
Honor `extensions.update.enabled` pref in GeckoView.  r=amejiamarmol,rpl,geckoview-reviewers

Comment 3

[Rob Wu [:robwu]]

Do we need UI or a warning that updates have been disabled in the add-on manager?

Do we need to add a way to update an individual add-on manually? The GeckoView API supports individual update requests.

Comment 4

[William Durand [:willdurand] [OOO until Aug. 25]]

(In reply to Rob Wu [:robwu] from comment #3)

Do we need UI or a warning that updates have been disabled in the add-on manager?

I don't think Desktop (in any channels) has any of that and I don't think this is really mandatory since that's only controlled by a pref. We should rather have UI for managing/checking updates of the different add-ons or all the add-ons at once as you mentioned.

Do we need to add a way to update an individual add-on manually? The GeckoView API supports individual update requests.

This is kinda Bug 1863857, no?

Comment 5

[Rob Wu [:robwu]]

(In reply to William Durand [:willdurand] from comment #4)

(In reply to Rob Wu [:robwu] from comment #3)

Do we need UI or a warning that updates have been disabled in the add-on manager?

I don't think Desktop (in any channels) has any of that and I don't think this is really mandatory since that's only controlled by a pref. We should rather have UI for managing/checking updates of the different add-ons or all the add-ons at once as you mentioned.

Agreed. On desktop, there is no warning because there is already UI (strings are at https://searchfox.org/mozilla-central/rev/7fc94186f1a759790c56e41a90ab350d78dbda30/toolkit/locales/en-US/toolkit/about/aboutAddons.ftl#236-245). On Android, the absence of UI means that users don't have an obvious way to see whether updating works.

Do we need to add a way to update an individual add-on manually? The GeckoView API supports individual update requests.

This is kinda Bug 1863857, no?

Yes.

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0439e1b8489d