1872267 - Setting a integer user preference via GPO with a value of 0 makes it a boolean

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[Mike Kaply [:mkaply]]

If you set a Preference policy like this:

"print.printer_VersaLink_C505.print_paper_size_unit": {
"Value": 0,
"Status": "user"
}

It ends up as false in about:config

We should keep the 0 int value.

Comment 1

[Mike Kaply [:mkaply]]

This was done on purpose in bug 1668374.

I need to find a better way.

Comment 2

[Mike Kaply [:mkaply]]

I think the best thing to do here is add an optional type on Preferences.

This is such an edge case, it's not worth overrotating

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1872267 - Allow setting an explicit preference type in policy. r?kcochrane

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d47e26b23ab
Allow setting an explicit preference type in policy. r=kcochrane

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9d47e26b23ab

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Bug 1872267 - Allow setting an explicit preference type in policy. r?kcochrane

Original Revision: https://phabricator.services.mozilla.com/D197534

Comment 7

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: Low
• String changes made/needed: None
• User impact if declined: Can't set certain pref policies correctly (parity with 123)
• Explanation of risk level: Policy only
• Code covered by automated testing: yes
• Is Android affected?: no
• Fix verified in Nightly: yes
• Steps to reproduce for manual QE testing: N/A
• Needs manual QE test: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/b34326dc6893